Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default method #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Kikobeats
Copy link
Contributor

Hello,

This default method is just to make this library a drop replacement for the original ms – What do you think? πŸ™‚

@lukeed
Copy link
Owner

lukeed commented Jan 15, 2024

I dunno, do people still use original? I'd have figured that these all became comp-time replacements at this point and/or that people really would have hated the "you get a different function based on arity" usage pattern...

If we were to do this, would need to do a bunch more d.ts and "exports" map changes to properly handle the default in ESM vs CJS

@Kikobeats
Copy link
Contributor Author

According to socket.dev, original is one of the most used package at npm:

Totally up to you, I thought a drop replacement will help this package to have more adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants