Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break(url): remove toDecode parameter #175

Merged
merged 2 commits into from
Aug 27, 2021
Merged

break(url): remove toDecode parameter #175

merged 2 commits into from
Aug 27, 2021

Conversation

lukeed
Copy link
Owner

@lukeed lukeed commented Aug 27, 2021

Turns out no one was using it except for polka@next, which stopped using it as of #172

Updated benchmarks while I was at it, using the latest Node 16 release. Here are the latest results 🎉

Benchmark: "/foo/bar?user=tj&pet=fluffy"
  url.parse        x   1,766,192 ops/sec ±0.59% (189 runs sampled)
  new URL()        x     254,742 ops/sec ±0.93% (188 runs sampled)
  parseurl         x   2,296,634 ops/sec ±0.43% (188 runs sampled)
  @polka/url       x   3,096,770 ops/sec ±0.56% (189 runs sampled)

Benchmark: (REPEAT) "/foo/bar?user=tj&pet=fluffy"
  url.parse        x   1,794,821 ops/sec ±1.01% (188 runs sampled)
  new URL()        x     258,587 ops/sec ±0.63% (189 runs sampled)
  parseurl         x  30,616,846 ops/sec ±0.47% (191 runs sampled)
  @polka/url       x 314,370,079 ops/sec ±0.36% (189 runs sampled)

Benchmark: "/foo/bar"
  url.parse        x   7,373,531 ops/sec ±0.63% (188 runs sampled)
  new URL()        x     291,642 ops/sec ±0.83% (189 runs sampled)
  parseurl         x  21,946,341 ops/sec ±0.93% (186 runs sampled)
  @polka/url       x  48,697,030 ops/sec ±0.49% (189 runs sampled)

Benchmark: "/"
  url.parse        x  10,744,706 ops/sec ±0.47% (188 runs sampled)
  new URL()        x     315,725 ops/sec ±0.86% (184 runs sampled)
  parseurl         x  46,863,886 ops/sec ±1.06% (189 runs sampled)
  @polka/url       x  72,862,914 ops/sec ±0.54% (190 runs sampled)

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #175 (1ca3dd7) into next (6ac6498) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              next      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          108       104    -4     
=========================================
- Hits           108       104    -4     
Impacted Files Coverage Δ
packages/url/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac6498...1ca3dd7. Read the comment docs.

@lukeed lukeed merged commit e45fe88 into next Aug 27, 2021
@lukeed lukeed deleted the break/url-decode branch August 27, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants