Added examples #48
Merged
Added examples #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeed
requested changes
May 23, 2018
examples/with-nextjs/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "next": "latest", | ||
| "polka": "0.2.3", |
There was a problem hiding this comment.
Let's bump this to latest as well 👍
examples/with-apollo/index.js
Outdated
| @@ -0,0 +1,52 @@ | |||
| const polka = require('polka') | |||
| const bodyParser = require('body-parser') | |||
There was a problem hiding this comment.
Let's import it as const { json } = require('body-parser') then update the usage below too
examples/with-nextjs/index.js
Outdated
| app.prepare().then(() => { | ||
| const server = polka() | ||
|
|
||
| server.get('*', (req, res) => handle(req, res)) |
There was a problem hiding this comment.
This can actually be server.get('*', handle) since the signatures match.
|
I'll actually make the changes really quick, you shouldn't have to worry about it 😄 |
lukeed
approved these changes
May 23, 2018
|
Thank you~! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples for Next.js and Apollo Server were added