-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors are not reporeted when thrown from before
contexts
#191
Comments
I also just noticed that if there is a failure in a |
Looks like the |
aomarks
added a commit
to google/wireit
that referenced
this issue
Mar 28, 2022
aomarks
added a commit
to google/wireit
that referenced
this issue
Mar 29, 2022
Adds a *watch* mode to Wireit which is used like this: npm run <script> watch It uses [https://github.com/paulmillr/chokidar](https://github.com/paulmillr/chokidar). Fixes #13 Some further optimizations will come in follow ups: #49 Also === - Added workarounds for lukeed/uvu#191. This was masking some errors that came up during this PR. - Refactored `ExecResult` into a class, because its API is growing. - Added an API for killing Wireit commands spawned from the test rig. Needed because `watch` doesn't exit by itself. - Added missing log event for a script running successfully.
This still seems to be an issue - any News? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
When using test suites, and a
before
throws an error, the only indication of the error being thrown is that the number of tests passed is 0 when there is 1 test in total.Expected Behavior
The error being thrown should be bubbled up and reported as any other error would be
Minimum Reproduction
You can find a reproduction of the error here
Reproduction steps
git clone cd uvu-context-error pnpm i / npm i / yarn node index
Other Information
I get the same outcome whether using
uvu
as a CLI (like thetest
script does) or calling the file directlyThe text was updated successfully, but these errors were encountered: