Fixing arrays of UUID #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The psycopg2 adapter being used for UUIDField didn't handle edge cases around arrays well and, in the case of an empty array of UUIDs, was not being registered. psycopg2 itself already includes a UUID adapter, so this commit switches to using it and registers the adapter at the module level. Regression tests have been added to ensure that arrays of UUIDs (both populated and empty) continue to work.
|
Will verify this soon and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psycopg2 adapter being used for UUIDField didn't handle edge cases
around arrays well and, in the case of an empty array of UUIDs, was not
being registered. psycopg2 itself already includes a UUID adapter, so
this commit switches to using it and registers the adapter at the module
level.
Regression tests have been added to ensure that arrays of UUIDs (both
populated and empty) continue to work.