Fix libsrtp #35
Closed
Fix libsrtp #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libsrtp compiled with -DCPU_RISC doesn't work properly on android/arm. Visiable effect: AES's self-test failed during srtp_init() CPU_RISC is used for optimization only, and CPU_CISC should just work just fine, it has been tested on android/arm with srtp test applications and libjingle. After srtp became usable it is safe to enable SDES by default.
|
What procedure do you use to run the tests on the phone? I see the Unittest.mk for the android, but how do you actually run it? |
bthemad
added a commit
that referenced
this pull request
Nov 28, 2012
… untill we test the performance penalty
|
Just enable sdes security in voice-client-core/jni/tuenti/clientsignalingthread.cc |
|
ok, I thought you somehow managed to run unit tests and found it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsrtp compiled with -DCPU_RISC doesn't work properly on android/arm.
Visiable effect: AES's self-test failed during srtp_init()
CPU_RISC is used for optimization only, and CPU_CISC should just work just fine,
it has been tested on android/arm with srtp test applications and libjingle.
After srtp became usable it is safe to enable SDES by default.