Skip to content
This repository has been archived by the owner on Mar 26, 2022. It is now read-only.

Issue #17 #18: Mac addresses #66

Merged
merged 7 commits into from
Oct 17, 2019
Merged

Issue #17 #18: Mac addresses #66

merged 7 commits into from
Oct 17, 2019

Conversation

vendi95
Copy link
Contributor

@vendi95 vendi95 commented Oct 8, 2019

Fixes #17
Fixes #18

Copy link
Owner

@luksan47 luksan47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found only minor things.
Have not checked the JS, and did not try it out, will do later.

app/Http/Controllers/InternetController.php Outdated Show resolved Hide resolved
app/Utils/TabulatorPaginator.php Show resolved Hide resolved
database/factories/MacAddressFactory.php Outdated Show resolved Hide resolved
resources/lang/hu/internet.php Outdated Show resolved Hide resolved
resources/views/layouts/navbar.blade.php Outdated Show resolved Hide resolved
app/MacAddress.php Outdated Show resolved Hide resolved
app/Http/Controllers/InternetController.php Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
Copy link
Contributor

@steakhal steakhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is quite long. Please next time consider multiple smaller ones.

app/Http/Controllers/InternetController.php Show resolved Hide resolved
app/Http/Controllers/InternetController.php Show resolved Hide resolved
app/Http/Controllers/InternetController.php Show resolved Hide resolved
app/Http/Controllers/InternetController.php Outdated Show resolved Hide resolved
app/Utils/TabulatorPaginator.php Show resolved Hide resolved
resources/lang/hu/internet.php Outdated Show resolved Hide resolved
@luksan47
Copy link
Owner

I don't really like the "loading" pop-up. Or at least, when the data loads fast, it makes no sense to blank the screen for a fraction of a second.
When it would be loading for ca. one second, it might be useful, but not as it is right now.

@vendi95
Copy link
Contributor Author

vendi95 commented Oct 14, 2019

I don't really like the "loading" pop-up. Or at least, when the data loads fast, it makes no sense to blank the screen for a fraction of a second.
When it would be loading for ca. one second, it might be useful, but not as it is right now.

We can modify the plugin later.

@luksan47
Copy link
Owner

I don't really like the "loading" pop-up. Or at least, when the data loads fast, it makes no sense to blank the screen for a fraction of a second.
When it would be loading for ca. one second, it might be useful, but not as it is right now.

We can modify the plugin later.

I think it's a must do issue, currently it's not too user friendly.

@luksan47 luksan47 merged commit 2d17964 into master Oct 17, 2019
@luksan47 luksan47 deleted the mac-addresses branch October 17, 2019 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAC slot request handling MAC slot request
3 participants