-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, found only minor things.
Have not checked the JS, and did not try it out, will do later.
database/migrations/2019_10_06_212436_create_mac_addresses_table.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is quite long. Please next time consider multiple smaller ones.
I don't really like the "loading" pop-up. Or at least, when the data loads fast, it makes no sense to blank the screen for a fraction of a second. |
We can modify the plugin later. |
I think it's a must do issue, currently it's not too user friendly. |
Fixes #17
Fixes #18