Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add getOperatorsOf(address) to LSP7 #698

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Conversation

YamenMerhi
Copy link
Member

What does this PR introduce?

⚠️ BREAKING CHANGES

🚀 Feature

  • add getOperatorsOf(address) to LSP7

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Changes to gas cost

Generated at commit: feca533839ef1b1e6b2bf70223b31c7cc2a32cb1, compared to commit: 9db488aad9065f88cfc3c5f43f47b1fab35fc5f0

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
LSP6SetDataRestrictedController supportsInterface +55 ❌ +10.24%
LSP6SetDataUnrestrictedController supportsInterface +55 ❌ +10.24%
LSP6ExecuteRestrictedController supportsInterface +55 ❌ +9.82%
LSP6ExecuteUnrestrictedController supportsInterface +55 ❌ +9.82%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
LSP6SetDataRestrictedController 2,860,468 (+21,623) execute
givePermissionsToController
restrictControllerToERC725YKeys
supportsInterface
18,490 (+136)
120,634 (+107)
138,884 (+55)
592 (+55)
+0.74%
+0.09%
+0.04%
+10.24%
28,535 (+82)
120,634 (+107)
138,884 (+55)
592 (+55)
+0.29%
+0.09%
+0.04%
+10.24%
28,535 (+82)
120,634 (+107)
138,884 (+55)
592 (+55)
+0.29%
+0.09%
+0.04%
+10.24%
38,581 (+28)
120,634 (+107)
138,884 (+55)
592 (+55)
+0.07%
+0.09%
+0.04%
+10.24%
2 (0)
1 (0)
1 (0)
4 (0)
LSP6SetDataUnrestrictedController 2,860,468 (+21,623) execute
givePermissionsToController
restrictControllerToERC725YKeys
supportsInterface
18,490 (+136)
126,634 (+107)
147,384 (+55)
592 (+55)
+0.74%
+0.08%
+0.04%
+10.24%
28,535 (+82)
126,634 (+107)
147,384 (+55)
592 (+55)
+0.29%
+0.08%
+0.04%
+10.24%
28,535 (+82)
126,634 (+107)
147,384 (+55)
592 (+55)
+0.29%
+0.08%
+0.04%
+10.24%
38,581 (+28)
126,634 (+107)
147,384 (+55)
592 (+55)
+0.07%
+0.08%
+0.04%
+10.24%
2 (0)
1 (0)
1 (0)
4 (0)
LSP6ExecuteRestrictedController 2,875,691 (+21,631) lsp20VerifyCall
supportsInterface
transferLYXToEOA
transferLYXToUP
transferNFTToRandomEOA
transferNFTToRandomUP
transferTokensToRandomEOA
transferTokensToRandomUP
14,896 (-3)
615 (+55)
56,165 (-998)
31,496 (+31)
129,961 (-903)
237,763 (-949)
72,683 (-4,408)
207,220 (-4,459)
-0.02%
+9.82%
-1.75%
+0.10%
-0.69%
-0.40%
-5.72%
-2.11%
17,032 (-3)
615 (+55)
56,165 (-998)
31,496 (+31)
129,961 (-903)
237,763 (-949)
72,683 (-4,408)
207,220 (-4,459)
-0.02%
+9.82%
-1.75%
+0.10%
-0.69%
-0.40%
-5.72%
-2.11%
17,745 (-3)
615 (+55)
56,165 (-998)
31,496 (+31)
129,961 (-903)
237,763 (-949)
72,683 (-4,408)
207,220 (-4,459)
-0.02%
+9.82%
-1.75%
+0.10%
-0.69%
-0.40%
-5.72%
-2.11%
17,745 (-3)
615 (+55)
56,165 (-998)
31,496 (+31)
129,961 (-903)
237,763 (-949)
72,683 (-4,408)
207,220 (-4,459)
-0.02%
+9.82%
-1.75%
+0.10%
-0.69%
-0.40%
-5.72%
-2.11%
8 (0)
24 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
LSP6ExecuteUnrestrictedController 2,875,691 (+21,631) lsp20VerifyCall
supportsInterface
transferLYXToEOA
transferLYXToUP
transferNFTToRandomEOA
transferNFTToRandomUP
transferTokensToRandomEOA
transferTokensToRandomUP
14,896 (-3)
615 (+55)
56,795 (+31)
33,496 (+31)
128,710 (+10)
236,512 (-37)
71,119 (-3,268)
205,656 (-3,319)
-0.02%
+9.82%
+0.05%
+0.09%
+0.01%
-0.02%
-4.39%
-1.59%
17,032 (-3)
615 (+55)
56,795 (+31)
33,496 (+31)
128,710 (+10)
236,512 (-37)
71,119 (-3,268)
205,656 (-3,319)
-0.02%
+9.82%
+0.05%
+0.09%
+0.01%
-0.02%
-4.39%
-1.59%
17,745 (-3)
615 (+55)
56,795 (+31)
33,496 (+31)
128,710 (+10)
236,512 (-37)
71,119 (-3,268)
205,656 (-3,319)
-0.02%
+9.82%
+0.05%
+0.09%
+0.01%
-0.02%
-4.39%
-1.59%
17,745 (-3)
615 (+55)
56,795 (+31)
33,496 (+31)
128,710 (+10)
236,512 (-37)
71,119 (-3,268)
205,656 (-3,319)
-0.02%
+9.82%
+0.05%
+0.09%
+0.01%
-0.02%
-4.39%
-1.59%
8 (0)
24 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)

Copy link
Member

@skimaharvey skimaharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamenMerhi YamenMerhi merged commit 4599e20 into develop Sep 5, 2023
26 checks passed
@YamenMerhi YamenMerhi deleted the getOperatorsOf branch September 5, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants