Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Squirrel to Velopack #199

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sshcrack
Copy link
Contributor

@sshcrack sshcrack commented Apr 25, 2024

Fixes issue #181 (maybe #192) . Migrated Squirrel to Velopack. Haven't tested updating yet and we'll have to handle Github Releases

I've made the UpdateManager a static public field in Updater to apply updates when the user clicks restart.

@sshcrack
Copy link
Contributor Author

sshcrack commented Apr 25, 2024

Alright, I'm setting up the csproj config, what should the packId be? RePlays? Also, we have to decide for a channel that velopack is going to use. I'm going for stable for now.
Folder structure looks like this:
grafik

@sshcrack
Copy link
Contributor Author

sshcrack commented Apr 25, 2024

To be done:
Github workflows.
I think a release has to be deployed manually first for velopack to create deltas and establish the update channel (and for the github workflow to work)

@sshcrack
Copy link
Contributor Author

Sometimes delta updates are not applied when just exiting the application without calling ApplyUpdatesAndExit if an update is pending.
Maybe we could add a exit hook to the application as well to apply updates. There's more info here

@sshcrack
Copy link
Contributor Author

@lulzsun what do you think?

@lulzsun
Copy link
Owner

lulzsun commented Apr 28, 2024

I'm holding off reviewing this until I have more free time. Since it sounds like this may introduce breaking changes, I'll have to properly test this myself before making decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants