Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUM-710] - Upgrade to Cosmos SDK v0.47.3 #28

Merged
merged 61 commits into from
Jun 29, 2023
Merged

Conversation

lebascou
Copy link
Contributor

@lebascou lebascou commented May 31, 2023

Upgrade Lum Network chain to Cosmos SDK v0.47.3.

⚠️ Warning ⚠️

This PR introduces multiple breaking changes. All modules and features, alongside all upgrade scenarios must be tested thoroughly.

Major changes include

  • Upgrade to Cosmos SDK v0.47
  • Migration to CometBFT
  • Upgrade to Ibc-go v7
  • Protobuf clean up and re-generation

Completion checklist

Changelog

  • Migration to CometBFT (Part 1)
  • Upgrade code to Cosmos SDK v0.47
  • Upgrade code to Ibc-go v7
  • Upgrade gogo/protobuf to cosmos/gogoproto
    • Paths fixed to abide to new mandatory format (lum-network -> lum/network)
    • Stride imported proto packages renamed into lum/network
  • GoLevelDB patch applied
  • ICS27 patch removed following Ibc-go upgrade
  • Crisis module registration and store migration
  • Makefile improvements
    • Fix all base commands (build, clean, install...)
    • Improve all dev commends (format, import ordering...)
    • Add all proto related commands (proto-format, proto-format-gencode, proto-lint, proto-gen, proto-check-breaking)
    • Add new sec command to run gosec
  • CI improvements
    • Add lint operation
    • Add format-check operation
    • Add sec operation

Notes

  • App Wiring not being used for the moment and not in the scope
  • Params migration not done

* master:
  Revert "Rebase to default icacontrollertypes storekey since genesis reset ignores previous store issues"
  Rebase to default icacontrollertypes storekey since genesis reset ignores previous store issues
  Ensure pool ports are properly set or reset
  Ensure channel restore does not trigger double registration
  Fix typo
  Remove upgrade handle for v1.4.2 since it will never be triggered
  Use slice instead of map to store validators and fix related codebase
  Fix double space typo
  Fix import naming consistency
  Format code and add comment
  Update keeper_withdrawal.go
  Apply upgrade plan
  Patch timeout timestamps
  Use counterparty channel id for transferring asset through ibc
@lebascou lebascou added the ready for review ⌛ PR ready for peer review label Jun 28, 2023
@lebascou lebascou added ready to merge 👌 PR ready to be merged and removed ready for review ⌛ PR ready for peer review labels Jun 29, 2023
@lebascou lebascou merged commit 52a11b7 into rc/v1.5 Jun 29, 2023
@lebascou lebascou mentioned this pull request Jun 29, 2023
@lebascou lebascou deleted the feature/lum-710 branch June 29, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge 👌 PR ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants