Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable turbosnap for Chromatic #4133

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

MEsteves22
Copy link
Contributor

In this run, Chromatic failed due to turbo snap. After doing some research, I found out that vite-plugin-turbosnap was needed.
However, after more research (here and here), it seems like turbo snap is not compatible with pull_request events on CI at the moment.
Thus, I'm disabling turbo snap until it's compatible with pull-request or we decide to change our workflows (in case we really need turbo snap for some reason).

It seems like it only supports on push events at the moment.
@MEsteves22 MEsteves22 requested a review from a team as a code owner April 8, 2024 14:32
@MEsteves22 MEsteves22 requested review from zettca and plagoa and removed request for a team April 8, 2024 14:32
@github-actions github-actions bot temporarily deployed to uikit/pr-4133 April 8, 2024 14:37 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-app/pr-4133 April 8, 2024 14:37 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4133 April 8, 2024 14:38 Destroyed
@zettca zettca merged commit 1f9c6aa into master Apr 8, 2024
15 checks passed
@zettca zettca deleted the chore/chromatic-turbosnap branch April 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants