Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HA autodiscovery and add total entities #630

Merged
merged 8 commits into from
Feb 5, 2023

Conversation

antibill51
Copy link
Contributor

Fix HA autodiscovery.

Add items from "total" topic into HA autodiscovery.

Optimizations are probably needed.

lumapu added a commit that referenced this pull request Jan 28, 2023
…AP with same SSID is there

fix endless loop in `zerovalues` #564
fix auto discover again #565
added total values to autodiscover #630
improved zero at midnight #625
@lumapu
Copy link
Owner

lumapu commented Jan 29, 2023

please check with latest version 0.5.78 it should include total values. Thank you for your fix attempt.

@antibill51
Copy link
Contributor Author

DynamicJsonDocument doc(128) to 256 (else mf=nul)
Fix unit problem for totals.
Fix topic problem for totals (else same as ch0)

Why not create a DTU entity grouping the totals, rather than repeating them for each inverter?

@lumapu
Copy link
Owner

lumapu commented Jan 29, 2023 via email

@antibill51
Copy link
Contributor Author

@lumapu
bd8de5f publish totals only once :)

@antibill51
Copy link
Contributor Author

Now, Yieldday and Yieldtotal from the total topic have no exp_after flag in autodiscovery.
Waiting for midnight to see if Yieldday reset work.

@lumapu
Copy link
Owner

lumapu commented Jan 29, 2023

@lumapu
bd8de5f publish totals only once :)

sure, don't know what happened too me 😅

@stefan123t
Copy link
Collaborator

@antibill51 maybe you take a look at the fix for #635 i think such a chunked request would solve the HA auto discovery problem too. Thanks!

@antibill51
Copy link
Contributor Author

@stefan123t I am interested in this kind of project to deepen my basics in code development. To be honest, I just discovered the term "prometheus metrics"... I'm not sure of the result, but I'll try to move on it as soon as possible. It's not easy to understand the whole of a project like yours, I took a while to make the previous few changes, but I'm someone who doesn't like to use a v0.5.41 when v0.5.7x exists ;)

lumapu added a commit that referenced this pull request Feb 5, 2023
@lumapu lumapu merged commit 7ee5e94 into lumapu:development03 Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants