MI integration in 0.5.82 #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to still work for 3rd Gen...
|
sieht sehr gut aus! Kommen auch Daten? |
lumapu
reviewed
Feb 8, 2023
src/hm/miPayload.h
Outdated
| } | ||
| */ | ||
| DPRINTLN(DBG_INFO, F("Inverter ") + String(iv->id) + F(": status msg ") + p->packet[0]); | ||
| } else if (p->packet[0] == (0x12 + ALL_FRAMES)) { // MI status response to 0x11 |
There was a problem hiding this comment.
ist das richtig? das steht 0x12 + ... muss das nicht 0x11 heißen?
There was a problem hiding this comment.
Das mit 0x92 paßt an der Stelle.
Die "kleinen MI" sind da etwas seltsam, weil zwei Antworten auf eine Anfrage kommen. Die "Großen" (4-kanaligen) sind dann wieder anders...
There was a problem hiding this comment.
Und ja, es kommen Antworten.
Allerdings (zumindest auf den ersten Blick) nicht mehr so "bilderbuchmäßig" wie in der vorherigen Version, vermutlich weil es noch an den repeats der requests auf allen Kanälen bei Ausbleiben der Antwort fehlt.
seems to work... Data is unclear (no packets received yet?)
compiles... for the rest still untested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to still work for 3rd Gen...