Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth popup is showing *a lot* #18

Closed
johanbrook opened this issue Jun 25, 2024 · 5 comments
Closed

Auth popup is showing *a lot* #18

johanbrook opened this issue Jun 25, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@johanbrook
Copy link

Hi! Thanks for building this super CMS β€” it's so nice and simple to quickly get something up and running πŸ™‡

Steps

  1. Visit a page or collection post in the CMS UI.

Expected

Get asked for auth the first time but no more (for a while).

Actual

I get asked for auth almost on every visit in the page editor. And, I can still access the said page even if I hit "Cancel" in the browser auth prompt.


It doesn't seem to follow a pattern. Maybe it's some very low timeout somewhere?

I'm on Safari 17.4.

@oscarotero
Copy link
Member

Hi.
That's weird. It works fine in Firefox and Chrome, but not in Safari.
The authentication method used is a basic http auth which is standard and should work the same for all browsers.

I'll take a look if it's a bug on Hono's middleware.

@oscarotero oscarotero added the bug Something isn't working label Jun 25, 2024
@oscarotero
Copy link
Member

I found the cause of this. Seems that Safari ignores completely the auth data for websockets.
LumeCMS opens a websocket in the edit page, to preview the changes.
I'll try to fix it.

oscarotero added a commit that referenced this issue Jun 26, 2024
@oscarotero
Copy link
Member

Okay, I just released a new version and it should work fine now. Feel free to reopen if it doesn't.

@johanbrook
Copy link
Author

Looks like it's solved for me now. Thanks so much!

Btw, I don't think version 0.5.3 was tagged correctly (it doesn't exist at GitHub). I now tested from the main branch: https://cdn.jsdelivr.net/gh/lumeland/cms@main/mod.ts.

@oscarotero
Copy link
Member

Ops, sorry. I forgot to create the tag. It's created now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants