Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make url settable and replace permalink with it #46

Closed
valtlai opened this issue Apr 6, 2021 · 2 comments
Closed

Make url settable and replace permalink with it #46

valtlai opened this issue Apr 6, 2021 · 2 comments

Comments

@valtlai
Copy link
Contributor

valtlai commented Apr 6, 2021

Pages already have the url property, so if we could make it settable, the permalink property could be removed in favor of it. I think it would be nice if the getter (currently url) and setter (currently permalink) had a same name. Also that’s how date works.

This would be a breaking change, but we’re at v0.x so maybe it doesn’t matter. However, we can always make permalink an alias of url and possibly remove that later.

@oscarotero
Copy link
Member

I like it! Yes, initially there was only the permalink variable, and then I created the url for convenience. But you're right that they are almost the same and url is more clear about its purpose.
I'm working on it.

oscarotero added a commit that referenced this issue Apr 6, 2021
@oscarotero
Copy link
Member

I close this because it's already implemented. It will be available in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants