-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(remark): Support for passing through remarkRehype configuration #517
Comments
Hi @marcus-crane |
Neat, I'll try and submit a PR sometime this week 🙂 |
@oscarotero Congrats on the launch of Lume 2! I was just about to get around to PRing this again and I've had it running for my site in production for a while now. Maybe I missed it but I didn't see any explicit mention of whether the 1.x branch is frozen now? If so, I guess I can just reopen the PR I had previously that was created against Lume 2? |
I think it has been implemented here: 7f123b2 but the MDX plugin doesn't support this yet. @oscarotero Maybe we should refer to the
|
Ah neat, thanks for the heads up |
Hi @marcus-crane . |
@kwaa good idea! |
Ah neat, I've upgraded my own site to v2.0 now and am successfully using the updates (from main branch currently) so I'm going to mark this issue as closed. Thanks again! |
Enter your suggestions in details:
Hey there,
I've been porting my site over to Lume, which has been quite enjoyable so far. My blog makes use of Littlefoot which is a small JS library for inlining footnotes.
With Lume, I'm also using Remark which is nice but by default, generates some footnotes with syntax that Littlefoot can't quite work with.
The fix for this is just to override how the footnotes are rendered but doing that requires being able to pass through some configuration to remarkRehype.
Unfortunately, it isn't possible to do this, as remarkRehype is initialised with some default settings and isn't reachable from
_config.ts
so I'd like to request that it be opened up for passthrough.On a side note, and some of this is really down to Deno using URLs as identifiers, I was pleasantly surprised at how easy it was to pull the remark plugin into my site's repo and make this modification locally.
The references within will break over time of course so I'd still like to request it as something officially supported but it makes me feel a little easier that it's possible to reach into Lume's bowels a little bit for small patches without having to say; fork the entire codebase (not that I would bother to get that far)
I'd be happy to try and contribute a PR as well, although I'd have to have a think about what a good API might look like. I was a bit surprised to see that none of the existing remark config made use of types too 😅
Thanks again!
The text was updated successfully, but these errors were encountered: