Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update matches different ignore file than build #88

Closed
fserb opened this issue May 2, 2021 · 4 comments
Closed

update matches different ignore file than build #88

fserb opened this issue May 2, 2021 · 4 comments

Comments

@fserb
Copy link
Contributor

fserb commented May 2, 2021

if you have a example.njk file and a site.ignore('example').

lume build will build example.njk correctly.

But if you run lume build --serve, it will detect the change, but not rebuild the file, because it will match the ignored list.

@oscarotero
Copy link
Member

I guess you want to ignore a folder named example, right?

Ok, that's a bug because it only check if the path starts with this pattern here

@fserb
Copy link
Contributor Author

fserb commented May 2, 2021

Exactly.

Yeah, I saw isIgnored(), but I couldn't find where in the code is the ignore filter for build, so they could be the same.

oscarotero added a commit that referenced this issue May 2, 2021
@oscarotero
Copy link
Member

This function is only needed for update. In build the files/folders are filtered here

I just made a change and now it should work fine. Can you confirm it, please?

@fserb
Copy link
Contributor Author

fserb commented May 2, 2021

Yep. It does work now. :) Thanks.

@fserb fserb closed this as completed May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants