Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO: canonical URL and deps: Update lume and reload cache #18

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

mskian
Copy link
Contributor

@mskian mskian commented Dec 12, 2023

  • canonical URL in the header it applies to all pages/posts

using url filter - https://lume.land/plugins/url/
testing on my lume sites no issues

<link rel="canonical" href="{{ url |> url(true) }}">

@mskian mskian marked this pull request as draft December 12, 2023 05:14
@mskian
Copy link
Contributor Author

mskian commented Dec 12, 2023

still some realtime test are pending

@mskian
Copy link
Contributor Author

mskian commented Dec 12, 2023

Tested it working well

<link rel="canonical" href="{{ url |> url(true) }}">

@mskian mskian marked this pull request as ready for review December 12, 2023 05:23
@mskian
Copy link
Contributor Author

mskian commented Dec 12, 2023

  • Update lume
  • Reload cache
"reload": "echo \"import 'lume/cli.ts'\" | deno run --reload --unstable -A -",

RUN: deno task reload

@mskian mskian changed the title SEO: canonical URL in header SEO: canonical URL and CORE: Update lume and reload cache Dec 12, 2023
@mskian mskian changed the title SEO: canonical URL and CORE: Update lume and reload cache SEO: canonical URL and deps: Update lume and reload cache Dec 12, 2023
@oscarotero
Copy link
Member

Thanks!
Why do you need to reload cache? I think this task is not needed.

@mskian
Copy link
Contributor Author

mskian commented Dec 12, 2023

Thanks!
Why do you need to reload cache? I think this task is not needed.

sometime it cached the module data
it's helps us to get fresh one while upgrading the lume or adding new plugin

it's optional command
we can use it when needed

personally i am using this

@oscarotero
Copy link
Member

Hmm, but when Lume is updated, the url of Lume and all plugins is changed, so we don't need to force the reload.
I guess you're importing some modules from the same URL but the data may change, right?

In this case, I wouldn't include this task here, because it's a task that you have to specify in your deno.json file.

@mskian
Copy link
Contributor Author

mskian commented Dec 12, 2023

Hmm, but when Lume is updated, the url of Lume and all plugins is changed, so we don't need to force the reload. I guess you're importing some modules from the same URL but the data may change, right?

In this case, I wouldn't include this task here, because it's a task that you have to specify in your deno.json file.

for now, I removed that option it's just an optional command for re-create the lock file/reloading the packages

I follow this command from here 😅 lumeland/lume#330

@oscarotero
Copy link
Member

Ah, got it.
Yep, maybe deno task lume upgrade should remove the lock file so it's regenerated from scratch. This is one of the reasons why I have "lock": false in my deno.json file :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants