Stop Pascalizing Enum Cases #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascalizing enum case names in restrictions can cause clashes (see lumeohq#154)
Added this macro because enums which contain non-pascalized cases due to 2a97fcd would trigger a clippy lint.
lkirkwood
force-pushed
the
case-sensitive-enums
branch
from
abe8ff8
to
938809c
Compare
Much the same as non_camel_case_types but clippy will still complain without this.
|
Had to change the allow lint to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #154, the current implementation pascalizes enum case names and can therefore cause clashes with valid XSDs.
I have replaced the default formatting for enum case names with just filtering and sanitization.
I also added an
#[allow(non_camel_case_types)]to generated enums in order to avoid this change triggering clippy lints.