Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to nest structs of arrays #41

Merged
merged 21 commits into from
Feb 16, 2022
Merged

Allow to nest structs of arrays #41

merged 21 commits into from
Feb 16, 2022

Conversation

CurryPseudo
Copy link
Contributor

@CurryPseudo CurryPseudo commented Dec 8, 2021 •
edited
Loading

An implementation of #29

  • Basic functionality
  • Integration test
  • Documentation
  • Fix the field layout in generated struct

Any advice for refactoring this PR is welcome :) @Luthaf @copying

@CurryPseudo CurryPseudo changed the title [WIP] Allow to nest structs of arrays Allow to nest structs of arrays Dec 9, 2021
@CurryPseudo
Copy link
Contributor Author

@Luthaf Please review again if you have time~

Luthaf
Luthaf reviewed Jan 31, 2022
View reviewed changes
Copy link
Member

@Luthaf Luthaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for you patience, I've had very limited time to work on this crate over the past months.

The new implementation looks pretty good, I would like to see some more documentation on the approach taken & the new functions added.

soa-derive-internal/src/input.rs Outdated Show resolved Hide resolved
soa-derive-internal/src/input.rs Outdated Show resolved Hide resolved
soa-derive-internal/src/refs.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@CurryPseudo
Copy link
Contributor Author

Add a module in each doc test to workaround rust-lang/rust#83583

Luthaf
Luthaf approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@Luthaf Luthaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for sticking around and carrying this to completion! If you want to rebase & cleanup the history feel free to, otherwise I'll squash merge the PR.

@CurryPseudo
Copy link
Contributor Author

Squash will be great :)

@Luthaf Luthaf merged commit cae10b9 into lumol-org:master Feb 16, 2022
@Luthaf
Copy link
Member

Luthaf commented Feb 17, 2022

This is published on crates.io in soa_derive_internal v0.11.1

@mangelats
Copy link
Contributor

Nice!

@mangelats mangelats mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luthaf Luthaf Luthaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CurryPseudo @Luthaf @mangelats