Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all databases using the JSON serialization format to use TOML instead #28

Closed
lare96 opened this issue Jul 17, 2016 · 2 comments
Closed

Change all databases using the JSON serialization format to use TOML instead #28

lare96 opened this issue Jul 17, 2016 · 2 comments

Comments

@lare96
Copy link
Member

lare96 commented Jul 17, 2016

I don't really like the idea of mixing and matching JSON/TOML
@lare96 lare96 mentioned this issue Jul 18, 2016
Closed
@lare96
Copy link
Member Author

lare96 commented Jul 18, 2016

It seems there's a serious bottleneck. Toml4j takes a whopping 625 seconds to parse item definitions while google-gson does it under one second.

I'm going to use JSON for all databases, and toml4j can remain for parsing small non-complex configuration files (luna.toml, dependencies.toml, etc.)

lare96 added a commit that referenced this issue Jul 18, 2016
@lare96
Fix issue #28, all databases now in JSON and no more TomlParser
ed8ec3b
@lare96
Copy link
Member Author

lare96 commented Jul 18, 2016

ed8ec3b

@lare96 lare96 closed this as completed Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lare96