Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support runtime directory #4

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

utkarshgupta137
Copy link
Collaborator

@utkarshgupta137 utkarshgupta137 commented Mar 30, 2023

XDG_RUNTIME_DIR is a part of the XDG Base Directory Specification.
I want to incorporate this crate in a couple of tools which require runtime_dir.

@lunacookies lunacookies merged commit 139aed6 into lunacookies:master Apr 15, 2023
@utkarshgupta137 utkarshgupta137 deleted the runtime_dir branch April 15, 2023 15:56
@utkarshgupta137
Copy link
Collaborator Author

Should we support the permission check for the directory, as mentioned in the specification? You can check the changes here: https://github.com/utkarshgupta137/etcetera/tree/runtime_dir_check.
Personally, I'm not a fan since we're returning Option, not a Result.

@lunacookies
Copy link
Owner

Hi, sorry for leaving this awhile, but how would you feel about maintaining this crate? I don’t feel strongly about this project anymore and you clearly have far more interest than I do, so I’d be more than happy to transfer crate ownership to someone who cares :)

@utkarshgupta137
Copy link
Collaborator Author

Hi, sorry for leaving this awhile, but how would you feel about maintaining this crate? I don’t feel strongly about this project anymore and you clearly have far more interest than I do, so I’d be more than happy to transfer crate ownership to someone who cares :)

Yeah, definitely. I plan to use this crate to replace the dirs/dirs-next crate, so I would be happy to maintain it. You can transfer the repo to me. Not sure what is the process for crates.io.

@lunacookies
Copy link
Owner

I’ve invited you as a collaborator on GitHub and an owner on crates.io!

@utkarshgupta137
Copy link
Collaborator Author

I’ve invited you as a collaborator on GitHub and an owner on crates.io!

Thanks, I've accepted both! I've raised another PR with minor doc changes & version bump.

@utkarshgupta137
Copy link
Collaborator Author

Should we support the permission check for the directory, as mentioned in the specification? You can check the changes here: https://github.com/utkarshgupta137/etcetera/tree/runtime_dir_check. Personally, I'm not a fan since we're returning Option, not a Result.

FYI, the xdg crate checks the runtime directory as per the spec: https://github.com/whitequark/rust-xdg/blob/v2.4.1/src/lib.rs#L301

@lunacookies
Copy link
Owner

I suppose a breaking change wouldn’t matter much since this isn’t a popular library, which isn’t at 1.0 anyway. How pedantic you want to be about following the spec is completely up to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants