-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable lapp to have advanced characters in enums #393
Merged
Tieske
merged 1 commit into
lunarmodules:master
from
nathanrpage97:fix/lapp-enum-constraint
Jan 5, 2022
Merged
enable lapp to have advanced characters in enums #393
Tieske
merged 1 commit into
lunarmodules:master
from
nathanrpage97:fix/lapp-enum-constraint
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
requested changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
would you mind adding an entry to the changelog?
Tieske
force-pushed
the
fix/lapp-enum-constraint
branch
from
January 5, 2022 13:03
a5c8747
to
0a2d30b
Compare
Tieske
approved these changes
Jan 5, 2022
thx @nathanrpage97 ! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 13, 2022
## 1.12.0 (2022-Jan-10) - deprecate: module `pl.text` the contents have moved to `pl.stringx` (removal later) [#407](lunarmodules/Penlight#407) - deprecate: module `pl.xml`, please switch to a more specialized library (removal later) [#409](lunarmodules/Penlight#409) - feat: `utils.npairs` added. An iterator with a range that honours the `n` field [#387](lunarmodules/Penlight#387) - fix: `xml.maptags` would hang if it encountered text-nodes [#396](lunarmodules/Penlight#396) - fix: `text.dedent` didn't handle declining indents nor empty lines [#402](lunarmodules/Penlight#402) - fix: `dir.getfiles`, `dir.getdirectories`, and `dir.getallfiles` now have the directory optional, as was already documented [#405](lunarmodules/Penlight#405) - feat: `array2d.default_range` now also takes a spreadsheet range, which means also other functions now take a range. [#404](lunarmodules/Penlight#404) - fix: `lapp` enums allow [patterns magic characters](https://www.lua.org/pil/20.2.html) [#393](lunarmodules/Penlight#393) - fix: `text.wrap` and `text.fill` numerous fixes for handling whitespace, accented characters, honouring width, etc. [#400](lunarmodules/Penlight#400) - feat: `text.wrap` and `text.fill` have a new parameter to forcefully break words longer than the width given. [#400](lunarmodules/Penlight#400) - fix: `stringx.expandtabs` could error out on Lua 5.3+ [#406](lunarmodules/Penlight#406) - fix: `pl` the module would not properly forward the `newindex` metamethod on the global table. [#395](lunarmodules/Penlight#395) - feat: `utils.enum` added to create enums and prevent magic strings [#408](lunarmodules/Penlight#408) - change: `xml.new` added some sanity checks on input [#397](lunarmodules/Penlight#397) - added: `xml.xml_escape` and `xml.xml_unescape` functions (previously private) [#397](lunarmodules/Penlight#397) - feat: `xml.tostring` now also takes numeric indents (previously only strings) [#397](lunarmodules/Penlight#397) - fix: `xml.walk` now detects recursion (errors out) [#397](lunarmodules/Penlight#397) - fix: `xml.clone` now detects recursion (errors out) [#397](lunarmodules/Penlight#397) - fix: `xml.compare` now detects recursion (errors out) [#397](lunarmodules/Penlight#397) - fix: `xml.compare` text compares now work [#397](lunarmodules/Penlight#397) - fix: `xml.compare` attribute order compares now only compare if both inputs provide an order [#397](lunarmodules/Penlight#397) - fix: `xml.compare` child comparisons failing now report proper error [#397](lunarmodules/Penlight#397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lapp fails to parse enums that have advanced characters
-()
due tostring.match
treating them as pattern matching elements. Switch to usingstring.find
withplain=true