Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and and related documentation #689

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Conversation

alerque
Copy link
Member

@alerque alerque commented Aug 16, 2022

No description provided.

@alerque alerque changed the title Update CI and and related documentation" Update CI and and related documentation Aug 16, 2022
@alerque
Copy link
Member Author

alerque commented Aug 16, 2022

Use as a GH Action (similar to what we did with Luarocks) isn't quite working yet, I have to finish sweet talking that little Alpine Linux container where everything is, but I have to run off to something else for a bit so dropping it here in draft mode for now.

@alerque
Copy link
Member Author

alerque commented Aug 18, 2022

I'm going to (at least temporarily) throw in the towel on setting up a GH Action for this. In particular that shouldn't hold up the next release. I have gotten it to work several ways that work for various situations, but each way has major cons. The containerized way I used for Luarocks does not work well here because Busted doesn't just need it's own dependencies but all the dependencies of every project it has to run on. That means dependency injection into the container and that's a mess.

I'll break out the related work out of this PR and we can look into other implementation methods that might be more generally useful to end users.

This is partly to force a publish to make sure our CI machinery is
working, but also to bring the style in line with Penlight, luassert,
say, and others in this org.
Copy link
Member

@Tieske Tieske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small comments.

.github/workflows/busted.yml Outdated Show resolved Hide resolved
.github/workflows/busted.yml Show resolved Hide resolved
.github/workflows/busted.yml Show resolved Hide resolved
.github/workflows/busted.yml Outdated Show resolved Hide resolved
busted-scm-2.rockspec Show resolved Hide resolved
alerque and others added 2 commits August 23, 2022 12:59
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
…aths

Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
@alerque alerque merged commit 24f420a into lunarmodules:master Aug 23, 2022
@alerque alerque deleted the ci branch August 23, 2022 10:07
@Tieske
Copy link
Member

Tieske commented Aug 23, 2022

The merge after approval now leaves the CI in a failed state. Some build jobs should probably not run? @alerque

@alerque
Copy link
Member Author

alerque commented Aug 23, 2022

I'll look into it. Something similar happened on say, starting there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants