-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and and related documentation #689
Conversation
Use as a GH Action (similar to what we did with Luarocks) isn't quite working yet, I have to finish sweet talking that little Alpine Linux container where everything is, but I have to run off to something else for a bit so dropping it here in draft mode for now. |
cda2f62
to
72a51d4
Compare
I'm going to (at least temporarily) throw in the towel on setting up a GH Action for this. In particular that shouldn't hold up the next release. I have gotten it to work several ways that work for various situations, but each way has major cons. The containerized way I used for Luarocks does not work well here because Busted doesn't just need it's own dependencies but all the dependencies of every project it has to run on. That means dependency injection into the container and that's a mess. I'll break out the related work out of this PR and we can look into other implementation methods that might be more generally useful to end users. |
Adapted from luacheck
This is partly to force a publish to make sure our CI machinery is working, but also to bring the style in line with Penlight, luassert, say, and others in this org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small comments.
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
…aths Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
The merge after approval now leaves the CI in a failed state. Some build jobs should probably not run? @alerque |
I'll look into it. Something similar happened on say, starting there... |
No description provided.