fix(tests): Drops flaky openresty-luajit test #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
requested changes
Aug 12, 2022
There was a problem hiding this comment.
I can't repro this locally either but it crashes all the time across a variety of projects in CI. I've had to disable it elsewhere too.
Besides the tweak below, lets rebase this to get the unrelated commit out of here so we have something easy to git revert later.
Co-authored-by: Caleb Maclennan <caleb@alerque.com>
|
Urgh. Hilariously, the failing test had apparently blocked me from pushing a previous approved commit, the cache change, to master. Removed that + added the suggested comment. |
alerque
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75