Fix crash after dohandshake() fails #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2016 16:37
The number of bytes received by ssl_recv() is being passed to luaL_addlstring() (in recvall()) but it was being left either uninitialized or being set to an error code. The crashing case I found was when the state was not LSEC_STATE_CONNECTED (e.g. when dohandshake() has failed) and ssl_recv() returned immediately without setting "got".
Fix crash related to incorrect buffer size
|
This appears to fix a pretty bad issue I've been trying to debug, but on the other hand: print(require("ssl.https").request("https://www.example.com/"))returns |
| for ( ; ; ) { | ||
| ERR_clear_error(); | ||
| err = SSL_read(ssl->ssl, data, (int)count); | ||
| ssl->error = SSL_get_error(ssl->ssl, err); | ||
| switch (ssl->error) { | ||
| case SSL_ERROR_NONE: | ||
| *got = err; | ||
| *got = 0; |
There was a problem hiding this comment.
Is this really correct? No error → no data?
There was a problem hiding this comment.
This is wrong following the documentation.
It must be: *got = err;
Closed
| return IO_DONE; | ||
| case SSL_ERROR_ZERO_RETURN: | ||
| *got = err; | ||
| *got = 0; |
There was a problem hiding this comment.
This line can be removed.
We have SSL_ERROR_ZERO_RETURN only if "err == 0". Since "*got = 0;" at the beginning, the line is useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of bytes received by ssl_recv() is being passed to luaL_addlstring() (in recvall()) but it was being left either uninitialized or being set to an error code. The crashing case I found was when the state was not LSEC_STATE_CONNECTED and ssl_recv() returned immediately without setting "got".