Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attributes on customer groups #1443

Conversation

ryanmitchell
Copy link
Contributor

This PR adds support for attributes on customer groups using the pre-existing conventions and approaches in the codebase.

I've not added any UI for managing these - I assume that would need done on the Filament branch later down the line?

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 11:00am

@glennjacobs glennjacobs added the enhancement Improvement to existing functionality label Jan 4, 2024
@glennjacobs glennjacobs added this to the v0.8 milestone Jan 4, 2024
@ryanmitchell
Copy link
Contributor Author

Any thoughts on this one?

@glennjacobs
Copy link
Contributor

Any thoughts on this one?

My initial reaction was to question why it was needed. Can you explain your use case?

@ryanmitchell
Copy link
Contributor Author

We have a few needs for this, the main one is that customer orders should be pushed to a 3rd party system using different 'channel ids' based on the customer group they are in. By allowing attributes this can be managed through the UI.

Beyond that we could show different messaging to customers based on their groups, and this could be controlled from the UI too.

@glennjacobs
Copy link
Contributor

@ryanmitchell I am happy to add attributes to customer groups, but I think adding this to 0.8 without the UI, but having it show under settings is wrong.

Maybe we should update this to be a 1.x PR where we can add the admin UI?

@ryanmitchell
Copy link
Contributor Author

No problem - closing in favour of #1726

glennjacobs added a commit that referenced this pull request May 22, 2024
This PR adds support for attributes on customer groups using the
pre-existing conventions and approaches in the codebase.

Replaces #1443

Co-authored-by: Glenn Jacobs <glenn@neondigital.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants