-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support attributes on customer groups #1443
Support attributes on customer groups #1443
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Any thoughts on this one? |
My initial reaction was to question why it was needed. Can you explain your use case? |
We have a few needs for this, the main one is that customer orders should be pushed to a 3rd party system using different 'channel ids' based on the customer group they are in. By allowing attributes this can be managed through the UI. Beyond that we could show different messaging to customers based on their groups, and this could be controlled from the UI too. |
@ryanmitchell I am happy to add attributes to customer groups, but I think adding this to 0.8 without the UI, but having it show under settings is wrong. Maybe we should update this to be a 1.x PR where we can add the admin UI? |
No problem - closing in favour of #1726 |
This PR adds support for attributes on customer groups using the pre-existing conventions and approaches in the codebase. Replaces #1443 Co-authored-by: Glenn Jacobs <glenn@neondigital.co.uk>
This PR adds support for attributes on customer groups using the pre-existing conventions and approaches in the codebase.
I've not added any UI for managing these - I assume that would need done on the Filament branch later down the line?