-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delims support for templates #48
Conversation
WAT @Crevil ? 😅 |
Pocket comment... is that a thing? |
Haha 😅 pocket email review response seems like a dangorous thing 🤯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave this another look. What is the reasoning for using delimns
with an n
?
Shouln't it just be delims
?
Thats a real good question 👍 🤦 Will fix! |
Was wrongly named `delimn`
Naming fixed 👍 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :D
This little improvement adds support for setting
--delimns
using theshuttle template
, so you can choose custom ones in templates, where{{
and}}
isn't great. These could be fx>>
and<<
like the ones used in the test.