Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delims support for templates #48

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Add delims support for templates #48

merged 2 commits into from
Jun 23, 2020

Conversation

emilingerslev
Copy link
Contributor

This little improvement adds support for setting --delimns using the shuttle template, so you can choose custom ones in templates, where {{ and }} isn't great. These could be fx >> and << like the ones used in the test.

@emilingerslev emilingerslev requested a review from a team June 19, 2020 10:06
@emilingerslev
Copy link
Contributor Author

WAT @Crevil ? 😅

@Crevil
Copy link
Member

Crevil commented Jun 22, 2020

Pocket comment... is that a thing?

@emilingerslev
Copy link
Contributor Author

Haha 😅 pocket email review response seems like a dangorous thing 🤯

Copy link
Member

@Crevil Crevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Crevil Crevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gave this another look. What is the reasoning for using delimns with an n?
Shouln't it just be delims?

@emilingerslev
Copy link
Contributor Author

Just gave this another look. What is the reasoning for using delimns with an n?
Shouln't it just be delims?

Thats a real good question 👍 🤦 Will fix!

Was wrongly named `delimn`
@emilingerslev
Copy link
Contributor Author

Naming fixed 👍 😊

Copy link
Member

@Crevil Crevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :D

@Crevil Crevil changed the title Add delimns support for template Add delims support for templates Jun 23, 2020
@emilingerslev emilingerslev merged commit 4bd7c78 into master Jun 23, 2020
@Crevil Crevil deleted the feature/delimns branch September 28, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants