Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go sdk #56

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Go sdk #56

merged 5 commits into from
Feb 17, 2021

Conversation

jweibel22
Copy link
Contributor

These additions are needed to allow access to the shuttle context and templating functionality via the go based sdk

@jweibel22 jweibel22 requested a review from a team February 17, 2021 11:23
Crevil
Crevil reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@Crevil Crevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Some minor comments.

The convinience functions for k8s manifest generation and dockerfiles are somewhat non-generic and Lunar specific, mostly the k8s manifest part.

Whether they belong here or in a Lunar plan sdk I'm not sure. What do you think?

pkg/sdk/context.go Outdated Show resolved Hide resolved
pkg/sdk/context.go Show resolved Hide resolved
pkg/sdk/context.go Show resolved Hide resolved
@jweibel22
Copy link
Contributor Author

jweibel22 commented Feb 17, 2021 •
edited
Loading

The convinience functions for k8s manifest generation and dockerfiles are somewhat non-generic and Lunar specific, mostly the k8s manifest part.

Whether they belong here or in a Lunar plan sdk I'm not sure. What do you think?

good point, let's put them in the "plan commons" lib instead.

@jweibel22 jweibel22 merged commit d7a9d0b into master Feb 17, 2021
@jweibel22 jweibel22 deleted the go-sdk branch February 17, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Crevil Crevil Crevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jweibel22 @Crevil