Listen to SIGINT and close scripts #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahlunar
approved these changes
Mar 23, 2021
Currently if a shuttle script is cancelled by sending a SIGINT signal the process running in a script is not signalled. This leads to orphaned processes and is especially an issue when launching web servers listening on a port that can only by used once. Here the second run of the script will fail as the port is already used. This change introduces a context.Context down through the call chain and the shell executor will listen for cancellations on this and signal the processes accordingly. The context is cancelled when receiving SIGINT. Module github.com/go-cmd/cmd is updated to the latest version which contains a more stable shutdown API.
Crevil
force-pushed
the
fix/script-exit-signal
branch
from
59a6602
to
d21e774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a shuttle script is cancelled by sending a SIGINT signal the
process running in a script is not signalled. This leads to orphaned processes
and is especially an issue when launching web servers listening on a port that
can only by used once. Here the second run of the script will fail as the port
is already used.
This change introduces a context.Context down through the call chain and the
shell executor will listen for cancellations on this and signal the processes
accordingly. The context is cancelled when receiving SIGINT.
Module github.com/go-cmd/cmd is updated to the latest version which contains a
more stable shutdown API.
Closes #59