Add new gulp task to 'gulpfile.js' for running mongo daemon. #505
Conversation
| @@ -75,3 +76,17 @@ gulp.task('build_server', () => { | |||
| .js | |||
| .pipe(gulp.dest('out/')); | |||
| }); | |||
|
|
|||
| const mongodb_path = './third_party/mongodb'; | |||
| gulp.task('start-mongo', runCommand(`${mongodb_path}/bin/mongod --dbpath ${mongodb_path}`)); | |||
There was a problem hiding this comment.
We are already using gulp.shell. So, can we just use gulp.shell() instead of runCommand()?
There was a problem hiding this comment.
Oh, I didn't know about 'gulp.shell'. I will look into it and fix it.
There was a problem hiding this comment.
@llighter I had to give you the information early but I couldn't. I'm sorry for that. Also, thank you for this work!
There was a problem hiding this comment.
@romandev It's fine. I was able to study this in more detail. :)
There was a problem hiding this comment.
@romandev I've found that now gulp do not recommend 'gulp.shell' anymore.
Here is blackList.json file at gulpjs repo.
Gulp recommend to use gulp-exec or child_process.
And according to gulp-exec docs, If you just want to run a command, don't use this plugin.
And gulp API docs use child_process like this.
// run a command in a shell
var exec = require('child_process').exec;
gulp.task('jekyll', function(cb) {
// build Jekyll
exec('jekyll build', function(err) {
if (err) return cb(err); // return error
cb(); // finished task
});
});
What should I use?
WDYT? PTAL :)
There was a problem hiding this comment.
Okay! Thank you for the information. If so, we can move this patch to gulp-exec or child_process.
And, once this patch is merged, you can also replace gulp-shell with gulp-exec or child_process in existing codes.
There was a problem hiding this comment.
@romandev ok, then I will replace gulp-shell with child_process in our code.
| @@ -9,6 +9,7 @@ | |||
| "@types/request": "^2.0.3", | |||
| "@types/run-sequence": "0.0.29", | |||
| "@types/supertest": "^2.0.3", | |||
| "child_process": "^1.0.2", | |||
There was a problem hiding this comment.
Even If we have to child_processs, do we really need this? The child_process modules is built-in library as far as I know. WDYT?
There was a problem hiding this comment.
If we can use the built-in library, it's a good idea to use it. I'll look into it too. :)
There was a problem hiding this comment.
But if you use gulp.shell, we might not need it :)
|
I'll close this PR for new PR. |
I applied the mongo daemon startup option to 'gulpfile.ts'
ISSUE= #503