Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable content__contains pattern #236

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

rjprins
Copy link
Contributor

@rjprins rjprins commented Jun 13, 2023

Thanks for the awesome lib! 🙏
I stumbled on some test cases where everything was the same except for the request contents and the contents only differed in some small details. This change seemed simple enough.

Copy link
Owner

@lundberg lundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @rjprins !

docs/api.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b014780) 100.00% compared to head (082940c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2756      2758    +2     
  Branches       417       417           
=========================================
+ Hits          2756      2758    +2     
Impacted Files Coverage Δ
tests/test_patterns.py 100.00% <ø> (ø)
respx/patterns.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rjprins
Copy link
Contributor Author

rjprins commented Jun 23, 2023

Friendly nudge 🏓 I think this is ready to merge.

@lundberg lundberg merged commit 33438de into lundberg:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants