Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/mobile push notifications #3209

Closed
wants to merge 9 commits into from
Closed

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Nov 27, 2019

Closes #ISSUE

Description:

Thank you! 🚀


For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #3209 into develop will decrease coverage by 0.65%.
The diff coverage is 37.5%.

@@             Coverage Diff             @@
##           develop    #3209      +/-   ##
===========================================
- Coverage    88.04%   87.39%   -0.66%     
===========================================
  Files          126      127       +1     
  Lines         1824     1848      +24     
  Branches       275      279       +4     
===========================================
+ Hits          1606     1615       +9     
- Misses         211      224      +13     
- Partials         7        9       +2
Impacted Files Coverage Δ
src/vuex/modules/index.js 100% <ø> (ø) ⬆️
src/vuex/modules/push-notifications.js 31.57% <31.57%> (ø)
src/vuex/modules/session.js 88.76% <60%> (-1.72%) ⬇️

@stale
Copy link

stale bot commented Dec 8, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 8, 2019
@stale stale bot closed this Dec 11, 2019
@jbibla
Copy link
Collaborator

jbibla commented Dec 11, 2019

go away stalebot

@jbibla jbibla reopened this Dec 11, 2019
@stale stale bot removed the stale label Dec 11, 2019
@stale
Copy link

stale bot commented Dec 17, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 17, 2019
@jbibla
Copy link
Collaborator

jbibla commented Dec 19, 2019

go away stalebot

@stale stale bot removed the stale label Dec 19, 2019
@stale
Copy link

stale bot commented Dec 25, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2019
@stale stale bot closed this Dec 28, 2019
@faboweb faboweb reopened this Jan 1, 2020
@stale stale bot removed the stale label Jan 1, 2020
@stale
Copy link

stale bot commented Jan 7, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 7, 2020
@stale stale bot closed this Jan 10, 2020
@faboweb faboweb reopened this Jan 13, 2020
@stale stale bot removed the stale label Jan 13, 2020
@stale
Copy link

stale bot commented Jan 19, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jan 19, 2020
@stale stale bot closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants