Panic with details for unimplemented features #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A better developer experience IMO than the current unexplained errors. Custom tests have "expectPanic" which fail when a panic() doesn't happen. Comment out panic() and expectPanic bool to work on a feature.
|
I'm fairly sure I'm only panicking for unimplemented features. All existing tests work, but there is a non-zero chance this may cause failures for users of undocumented/untested/undefined features. Probably for the best though, since we'll find out what those are. |
|
No response in over two months. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better developer experience IMO than the current unexplained errors.
Custom tests have "expectPanic" which fail when a panic() doesn't
happen.
Comment out panic() and expectPanic bool to work on a feature.
Pulled out of #63