[pull] master from chromium:master #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3303d7f44c6a..e45388936649 2021-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,gavinmak@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: apolito@google.com,gavinmak@google.com,sokcevic@google.com,ajp@google.com Change-Id: I245d6119faa192d02cdbd52c1bad73d1eb2359da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198546 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927804}
In r925962 we landed a patch to avoid the regression/crash reported in https://crbug.com/1248710. The idea was to avoid creating the line_start_result when the fist-safe position exceeded the value of the non-hangable-run-end, instead of the actual break-opportunity offset got from the new BreakIterator (we've changed its default behavior to break after the whole space sequence). However, this change caused different results in the evaluation of the need of a line-end reshape, some lines bellow in this ShapeLine logic. This change implied unneeded reshapes that lead to the performance regression described in the bug 1254284. The solution to avoid the perf regression was to move the logic to evaluate the need of a line-end reshape before we adjust the breaking opportunity offset to the non-hangable-run-end. Finally, this CL is also fixing a typo in the crash-test added in r925962, precisely to provide as regression test for the reported issue. Bug: 1254284 Change-Id: I1cf747f3cfb4dd7c55950502ebdcc1be96d2f815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199791 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#927805}
This keeps happening to me... Change-Id: Iebc035c4c93a8152c44b75757e87cf53027afcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202712 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Sky Malice <skym@chromium.org> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#927806}
The crash is because context lost while creating WrappedSkImage, fix the problem by checking the context lost, and failing it early. Bug: 1255035 Change-Id: Iac5ef4dd14744a692f514266cec20658f033dc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199216 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#927807}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18c67bd363ef..7452274dca2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC romanarora@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1225326,chromium:1227330,chromium:1254717 Tbr: romanarora@google.com,lgrey@google.com Change-Id: Ib6f730fcc10a4105270c66576159380cf0ab7dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199422 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927808}
Bug: 1245513 Change-Id: I6c5355d2d395aedfa78f8166fbc097577aa162d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202516 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/main@{#927809}
This revises some strings according to latest write-up review. Bug: 1241169 Change-Id: I5c2e52610e6df828a13c980304a0ee438a831efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200550 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/main@{#927810}
https://android.googlesource.com/platform/external/perfetto.git/+log/588a25f21493..bf487cf7d6c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I290f2794f0cc30f22d29df3b81c8da421d0676d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200441 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927811}
https://chromium.googlesource.com/angle/angle.git/+log/57f67599d8bb..a44197b5ac77 2021-10-04 yuxinhu@google.com Tests: Add Mini World Creata Trace 2021-10-04 jmadill@chromium.org Update shader translator docs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: angle_perftests --gtest_filter="*mini_world*" Change-Id: I1018b4be1f333a147f8a8fc196572e7d251a69d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198544 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927812}
https://skia.googlesource.com/skia.git/+log/e03f1c101c66..0dc6445a46ea 2021-10-04 michaelludwig@google.com [graphite] Define SortKey as part of DrawPass impl 2021-10-04 drott@chromium.org Avoid finding a font with simulations 2021-10-04 johnstiles@google.com Reland "Disallow constructors of ES3 types in ES2 code." 2021-10-04 johnstiles@google.com Avoid returning a DSLExpression with an invalid type. 2021-10-04 bsalomon@google.com Enable bind texture 0 workaround for MSAA-RTT on Mali-Gxx. 2021-10-04 johnstiles@google.com Move 'is builtin code' flag into the ProgramConfig. 2021-10-04 johnstiles@google.com Add tests for constructors of private types. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Id295ded4905d49f0142d1c27467ab76ff566e572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198545 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927813}
Allows us to handle cases where the user triggers an IPH promo but then interacts with a UI feature that would interact badly with the promo bubble (without dismissing the bubble). This causes serious rendering issues on Mac when, for example, the user triggers the omnibox while an IPH bubble in the same area of the screen is showing. (See attached bug.) This CL adds a way to close non-critical promos overlapping a screen region, and uses it to dismiss bubbles overlapping the Omnibox drop-down when the user types into the location bar while a promo bubble is still visible. Bug: 1225046 Change-Id: I494afe7482d650564811fec771798d5dfa950ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198199 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#927814}
R=jennyz@chromium.org Bug: none Test: cq Change-Id: If7422d3ed24832ecf4f221b5ae4860709d37c68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199095 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#927815}
This CL updates the mock app on unbranded Chromium to show instructions for building branded Chrome instead. Bug: b/201786849 Change-Id: I5239447e1dc97fb63b62a477ba5a73a13783013c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201038 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/main@{#927816}
NativeUI View with MVC approach for chrome://management on Android. This page is intended to inform the end user about the account management status. This is the first of three CLs. 2nd one is going to link the actual Management state via JNI through ManagedBrowserUtils.java 3rd one is going link the "Managed by" menu item to the chrome://management page. Screenshots Not managed: https://storage.cloud.google.com/chromium-translation-screenshots/357099fd9d8a8bf44dde4a91378a52e4ac6f3643 Managed (unknown manager): https://storage.cloud.google.com/chromium-translation-screenshots/72de330589dc0fda168117491c2d3e028d27afe9 Managed (known manager): https://storage.cloud.google.com/chromium-translation-screenshots/b02f038ccd57988410ab3f87c9a2f4d3100cacd5 Bug: 1121153 Change-Id: I0a03553fac0a8b8f4c87dab120f2825da4ac6914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139403 Commit-Queue: Egor Pasko <pasko@chromium.org> Auto-Submit: Og Astorga <ogastorga@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#927817}
This reverts commit b37e479. Reason for revert: The original CL forgot to refactor a Chrome-branded code path. Original change's description: > Revert "[pdf] Change IsPdfExtensionUrl() to IsPdfExtensionOrigin()" > > This reverts commit db57e30. > > Reason for revert: breaks builds in several perf bots > https://ci.chromium.org/ui/p/chrome/builders/ci/linux-builder-perf/349623/overview > > Original change's description: > > [pdf] Change IsPdfExtensionUrl() to IsPdfExtensionOrigin() > > > > The check really pertains to the origin, not the entire URL. It also > > allows for a merging of logic between IsPdfExtensionOrigin() and > > IsPdfInternalPluginAllowedOrigin(). Furthermore, it makes the function > > more appropriate for security checks. > > > > Use IsPdfInternalPluginAllowedOrigin() in the implementation of > > ChromePrintRenderFrameHelperDelegate::GetPdfElement(). > > > > Change-Id: Ia8a6bb99a9e2d19b8bc857525ac74ac93e29c565 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200416 > > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#927504} > > NOTREECHECKS > > Change-Id: Id8f4ceb05d79e5f93af6e42aaaae8398103b3ed8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201368 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Johann Koenig <johannkoenig@google.com> > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Owners-Override: Johann Koenig <johannkoenig@google.com> > Cr-Commit-Position: refs/heads/main@{#927565} Change-Id: I0100f02a77f500f4809fddcbdb46467e8a7022f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202331 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#927818}
Bug: 1198187 Change-Id: I0919503c755177c4f803b63b63509458c6a5a6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200199 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Dodd <gavindodd@google.com> Cr-Commit-Position: refs/heads/main@{#927819}
Bug: 1254162 Change-Id: I8f6154d22f86d51f1898b49b34432793b24d71c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200200 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Simon Pelchat <spelchat@chromium.org> Cr-Commit-Position: refs/heads/main@{#927820}
Adds/Renames lacros stability switches so that we have entries that map to the beta and stable components. Bug: 1252184 Change-Id: I700e9023dffa44bfb4b32c7ba979e4c74d6358fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198322 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/main@{#927821}
This CL renames all "Task" identifiers in PasswordStoreAndroiBackend and friends to "Job" (e.g., TaskId --> JobId, TaskHandler --> JobReturnHandler) to avoid overloading the meaning of tasks. Bug: 1217070 Change-Id: I3830101ddc2220a0ef20f922f6041e3393239b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199790 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/main@{#927822}
Bug: 1234307 Change-Id: I72316ccabab272e5fd1a4c92676a6bfbb5a6f586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195790 Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#927823}
BUG=1253661 Change-Id: I445f3016d5483fc79d3de35b788d9dd908ef92ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189174 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#927824}
During WebAuthn requests, we figure out whether a given security key knows any of the credential IDs on the request's allowCredentials or excludeCredentials parameter by sending a series of silent (i.e. no user presence check) getAssertion CTAP requests for the relevant credential IDs. In order not to let websites force Chrome into making large number of CTAP requests, which could potentially take many seconds, we bound the size of these lists to 64 credential IDs. The renderer will return an error if this size is exceeded and the browser will silently ignore anything beyond 64 IDs. Also filter duplicate IDs, because otherwise sites can arbitrarily amplify probing duration with only a single credential ID (up to the maximum list size introduced here). This CL also changes PublicKeyCredentialDescriptor CBOR marshaling and parsing to include the `transports` fields. This field had previously been omitted since it generally isn't interpreted by security keys. But including it is useful in testing these changes, and the additional CTAP message overhead is minimal. Bug: 1248862 Change-Id: Ifa05bc17a05a8ab2213159fff88b8b94f976a45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194760 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/main@{#927825}
Change-Id: Ib0a8fa0e98d8faeb91740b4c953c4a0e406e2c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203110 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927826}
Windows: http://screen/eZKkR9EyQxGNqRh.png Mac http://screen/ARRRayphygC55Uk.png Bug: 1252988 Change-Id: I4e9e7a21522361f2e85bd217c0e3eb136ec31a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198346 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Orin Jaworski <orinj@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/main@{#927827}
- Adds alt text and tabindex to allow Chromevox to announce connecting spinner when displayed to match network-icon behavior. - Adds i18n behavior mixin to icon element and updates type definition for diagnostics-network-icon. Corrects @fileoverview position as part of fixing closure definition. - Tests correct alt text added to spinner. --gtest_filter=DiagnosticsApp* Bug: 1197335 Test: testing/xvfb.py out/Default/browser_tests Change-Id: Ia76e1bbd0bd5ca0f455d4a1d8955d1b0edde53fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198552 Commit-Queue: Ashley Prasad <ashleydp@google.com> Auto-Submit: Ashley Prasad <ashleydp@google.com> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927828}
- Renames css rule from no-ethernet to troubleshooting. - Changes font weight to regular and size to 13px. - Adjust font color for link to google-600. Screenshot: http://shortn/_vw6Q1vmbsG UX Spec (figma access required): http://shortn/_u7uQ8CmIPS Bug: 1197335 Change-Id: Iddaf39bafd3564caa8944163d815f7e52240967e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202304 Commit-Queue: Ashley Prasad <ashleydp@google.com> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#927829}
Bug: 1236276 Change-Id: Iea7d1f470b67b19896341ffafcb05525a29c723b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198787 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jiaming Cheng <jiamingc@chromium.org> Cr-Commit-Position: refs/heads/main@{#927830}
Androidx custom lint checks were disabled due to using newer APIs than the lint version we were using allowed. Now that we have updated to lint version 7.0.0, these checks are working again. The new --remove-fixed flag is also turned on in lint.py so that baseline.xml files do not keep growing but get trimmed when fixes are merged. Bug: 1225326, 1111416 Fixed: 1225326 Change-Id: I6b82c27a5b3f717137cdb5285718050b1ae532c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200345 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/main@{#927831}
Adding latest changes from upstream maldoca repo (d4ff0da335533ca2a662225aa5ef38c818f69c1b) and fixing the variable initialization error found by linux msan. Bug: 1254730 Change-Id: If69518506124f0b50e66fafa61079bbe7c321966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200336 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Olabode O. Anise II <anise@chromium.org> Cr-Commit-Position: refs/heads/main@{#927832}
https://android.googlesource.com/platform/external/perfetto.git/+log/588a25f21493..bf487cf7d6c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iac9cd76a8ffbc43eaf4ce9ab9a8421897a01a7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199347 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927833}
https://chromium.googlesource.com/catapult.git/+log/867bc56485ef..6c9150a9a8fc 2021-10-04 wenbinzhang@google.com [Dashboard] Mark alert as recovered if the related test is deleted If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1253975 Tbr: sadrul@google.com Change-Id: I21f2938172c429b4cef6e8e3fa1bda55f8e80018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203317 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927935}
EventLatency histograms are documented in histograms.xml files using deprecated suffix style. This CL moves them to use the new patterned style as a follow-up to crrev/c/3165979. Bug: 1243577 Change-Id: Iefc5f9d3cedf52dd202453390bc07e0da661f3fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3182702 Auto-Submit: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/main@{#927936}
https://android.googlesource.com/platform/external/perfetto.git/+log/588a25f21493..6a46cc75169a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I061c4439a2ded6a85e55ee60a596e0fb6c829df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203730 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927937}
Add a RunLoop::Run trace event to make it easier to understand when we are in a nested runloop. R=gab@chromium.org BUG=1043616 Change-Id: If92a104714ea4b510227bae056e63d8940d90e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228541 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/main@{#927938}
- Introduces 6 V2 interfaces in |AssistantClient| to support timer related functionality: * AddTimeToTimer * Pause/Remove/ResumeTimer * GetTimers * RegisterAlarmTimerEventObserver - Refactors |TimerController| to use newly introduced APIs. - Cleans up |assistant_manager_internal_| in |TimeController|. - Updates timer_controller_unittests.cc Bug: b/193148652 Test: unittested Change-Id: I5261624973fd0e5b7882c8ba63b630092ec74298 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3047738 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/main@{#927939}
Bug: None Test: Manual Change-Id: Ib8f635c97d15427d0c60afd6f2827315ca91f27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198054 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927940}
For some reason these are all incorrectly indented. Fix them in their own CL before landing a new browser test to ensure new changes don't get lost in the indentation haze. Bug: 1254243 Test: git cl format --js Change-Id: I90d4b6e58635aac046a2543a6d652970d5b92f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195681 Reviewed-by: Bo Majewski <majewski@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/main@{#927941}
Bug: 1174652 Change-Id: Ib6ee27d0da9d00861bcd491e195a28adc6c35312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202309 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/main@{#927942}
The test no longer exists and is triggering linter error on presubmit. Change-Id: Ie678c3a2a95bc6cb09c40892f2e92c5818df8d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204250 Commit-Queue: Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927943}
For some reason, we were calling the backend to cluster an empty visits vector, because we didn't have an early-exit case for that. This CL fixes that issue. Bug: 1255318 Change-Id: I8cba41e2d6fa00b1f9b5a6391f57a75cd6d7366f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203035 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/main@{#927944}
https://screenshot.googleplex.com/C76cfgfiBtcFeRN.png Bug: 1221297 Change-Id: I385ed99f4c51671cda8533c12ac58de183d23245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192350 Commit-Queue: Matt Walliser <mattwalliser@google.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#927945}
We would want to check the histogram when the Storage Service is shipped. Bug: 1255890 Change-Id: Ibb85a14500dc4c882f16f0d68fa55a9fba68b2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203991 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/main@{#927946}
The 'Check network' button in optin dialog depends on ButtonARCNetworkDiagnostics, EnableNetworkingInDiagnosticsApp, and DiagnosticsAppNavigation features. In this change we're only enabling ButtonARCNetworkDiagnostics so the feature will remain disabled effectively until the other two features are enabled. BUG=b:197314676 TEST=none Change-Id: If534b8fdb394fb5334dc35fba6ea17e881b46c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204011 Reviewed-by: Long Cheng <lgcheng@google.com> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/main@{#927947}
Tests started failing as a result of autoroll: https://chromium.googlesource.com/chromium/src/+/9b02a4a9b6b9357073086c432a9e1965b6bb7541 Rebaseline the tests for Mac10.12 so that they pass. Bug: 1256071 Change-Id: I890c79a196d2fd0100991537d451706b5613d5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204070 Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927948}
This reverts commit 44f8ff2. Note: this wasn't auto generated, the auto generated reland would not submit for some reason. Reason for revert: Fixed tests Original change's description: > Revert "Remove calculator offline manifest." > > This reverts commit 1b903ed. > > Reason for revert: Broke All/PreinstalledWebAppsBrowserTest.CheckInstalledFields/WebAppsCrosapiDisabled, see crbug.com/1254257 > > Original change's description: > > Remove calculator offline manifest. > > > > When using a offline manifest the calculator will always populate in the > > app tray but will only be downloaded on first launch. This ends up > > causing broken experiences for offline and demo mode users. This cl > > updates the calculator PWA to install on start up and only replace the > > legacy chrome app once successfully installed. > > > > Bug: b/200761949 > > Change-Id: Iebc39b386615baa936ace6e675dac0b011396a02 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189530 > > Commit-Queue: Zain Afzal <zafzal@google.com> > > Reviewed-by: Alan Cutter <alancutter@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#926090} > > Bug: b/200761949, 1254257 > Change-Id: Ifff162fbcc5ee70a8712f7dd7c6c9b5e7117b849 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193992 > Owners-Override: Marc Treib <treib@chromium.org> > Auto-Submit: Marc Treib <treib@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/main@{#926194} Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/200761949, 125425 Change-Id: Ia3fe8e57fa1a30a3682c824574b0e5772fab4158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197891 Reviewed-by: Alan Cutter <alancutter@chromium.org> Reviewed-by: Zain Afzal <zafzal@google.com> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/main@{#927949}
The ash version needs a specific font. Change-Id: I51631935ce3b57d0f2a53ee238d83abba8bc2f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200320 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/main@{#927950}
This CL literally just renames methods Set() -> Add(), and SetWebFeature() -> AddWebFeature(). PrivacyBudgetMetricsBuilder::Set() was incorrectly named since rather than setting the metric, it adds them to the existing set of metrics. Ditto for SetWebFeature(). Fixed: 1132946 Change-Id: Ifef4f49668f6e3034321ef24d3a1d9f431b56203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202513 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/main@{#927951}
That Profile tracked the ExitType was really just a convenience, and should be separate from Profile. This moves most of the code (I'll move more later) out of profile into its own Service. I'm doing this for two reasons: 1. the code doesn't really belong in Profile. 2. There needs to be more finer grain control over when the value is changed. This doesn't belong in Profile. BUG=294444 TEST=covered by tests Change-Id: I5d68539f438ae58623bc5bee28d9e436352c71b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199041 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#927952}
…terprise deep scanning providing a serialized protobuf. Instead, base64 encode this field, like other non-UTF-8 fields on chrome://safe-browsing base: :Values expect the string values to be valid UTF-8, but we were Change-Id: I744ccba4efa12f044e313f4585cc93f4a253e505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200132 Reviewed-by: Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#927953}
When the user drags an app icon to the bottom edge of the bubble, the grid auto-scrolls. However, the user may intend to drag the icon to the shelf to pin it. Having the grid auto-scroll while the shelf icons are responding to the drag feels strange. Stop auto-scrolling when the mouse is more than 8 pixels outside the bubble. This allows auto-scrolling when the mouse is in the padding area between the bubble and the shelf, but stops scrolling when the mouse enters the shelf. Bug: 1254120 Test: added to ash_unittests Change-Id: Iadcf3065974252214bf55263a4f8cb4ae00aed97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203517 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#927954}
Add checkbox to AutoDark AppMenu item and update text accordingly. Bug: 1253648 Change-Id: Ic52a43fce900ada8415ce1792700b2046d3016d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188841 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Commit-Queue: Neil Coronado <nemco@google.com> Cr-Commit-Position: refs/heads/main@{#927955}
This is to react to tapping Settings link in the notice card. Bug: 1255951 Change-Id: I46f8969df5050b6a01c1f26327503ab7b6654539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200680 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/main@{#927956}
This reverts commit c901370. Reason for revert: Initially unpausing was done when mojo strong binding is disconnected. After the change OomInterventionImpl object is not destroyed with the binding and keeps living in the renderer process, holding ScopedPagePauser. It results in load hang after user declines intervention in NearOomReductionInfobar. Original change's description: > Use DEFINE_STATIC_LOCAL for OomInterventionImpl > > This CL uses DEFINE_STATIC_LOCAL for OomInterventionImpl that has > a process-wide receiver instead of MakeSelfOwnedReceiver<T>. > > Bug: 1176590 > Change-Id: Iffa906aadb29d3063efc3b7751ba28198a219cb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2772672 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#867929} Bug: 1176590 Change-Id: Icee36a958051e97e3b643421becea70f92599bf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3196412 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/main@{#927957}
Roll Chrome Linux PGO profile from chrome-linux-main-1633348314-d02af1c661bbb2a462867842b18040e6aa068fb4.profdata to chrome-linux-main-1633391873-f6f556d2fafbf395d3f75b48642d17f5e1c98a7f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I30e3fdb4230c3abad451dda78497ae6eb069baa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203459 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927958}
They will be used for obtaining page load tokens in a follow-up CL. Bug: 1240403 Change-Id: I744e14adb7882e94c0f6299c7fc1dfa7f7add2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3139408 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/main@{#927959}
ContentSuggestions.Feed.WebFeed.FollowCount.Engaged is reported when interacting with either feed. Bug: b/201837028 Change-Id: Ib319563ebd193045e09f22575fe11ee7cbaa458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202497 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/main@{#927960}
Change-Id: I66f93ad6ed3f5cd743d111b12fc1a81e8b79178b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203733 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#927961}
This is behind a feature param - just a tool in case content extraction doesn't work well enough Bug: 1171352 Change-Id: Id150dc4886f0f6f800fa1ee9fe57f610215effb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202975 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#927962}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )