[pull] master from chromium:master #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
When components/arc/input_overlay/resources/input_overlay_resources.grd was added in https://crrev.com/c/3107714, the file was not added to resource_ids.spec. This led to resource id collision when building Cros under debug mode (https://crbug.com/c/3167663). The problem is mitigated in https://crrev.com/c/3200036. This CL fixes the root cause by adding the missing entry. Also: * Fix overlap between chromeos/ and components/ sections. * Refresh resource_id.spec values, and add instructions on how to do so. Change-Id: Id2541d53684333e44d629bfa2f281aa79e37ea81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198216 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/main@{#927963}
This CL includes updates to the HaTS message implementation to keep in line with the existing infobar behavior on events associated with the tab where the prompt is displayed. The primary issue that is being targeted here is that the message prompt currently shows up even after the survey has expired. To avoid this, the message will be dismissed when the original tab where the message was displayed is hidden for any reason. Bug: 1254789 Change-Id: Ida34c9f4c2c3e0a428468b5b861fceaa9053d0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198140 Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/main@{#927964}
From UX feedback, we want to only show preview image in the settings UI if user is currently using a deprecated default image. Expected current behavior: https://screenshot.googleplex.com/4QmbnTptkGWxZgy.png Actual current behavior: https://screenshot.googleplex.com/9uUCFLkUfExZC9K.png After the change: https://screenshot.googleplex.com/4dJstrcQADXCFQc.png Since all the default images containing author and website info has been deprecated, revise related logics. Also cleanup default_user_image.cc as a preparation for supporting re-ordering default images in personalization settings. Bug: b/201001054 Test: Run existing tests Change-Id: Ia995d367103692b42a59e6b63c8bfb3226be40c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192962 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Reviewed-by: Yuki Awano <yawano@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/main@{#927965}
This will be used to perform a finch experiments. BUG=b:198533669 TEST=Add "--enable-features=ArcGuestZram:size/268435456". Change-Id: I33412741633dba9bd511f114a221d690ef54c48c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199903 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/main@{#927966}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633359549-b5cd1322714ca00cf7adcc0663ba780c484e2474.profdata to chrome-win64-main-1633381085-b15eb1fa1f8116ecc8dbb0b3bb76dfefb4daa734.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2fde123da70f99a788a074e4452b925d26a120d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204235 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927967}
Roll Chrome Mac PGO profile from chrome-mac-main-1633348314-b48333aa3c6038206ce18a8065a07ef5db095721.profdata to chrome-mac-main-1633391873-479cd943e27249bc9be149ef0ae8072d8163aa9d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9c2d72e7d3a1ce16f8d1b08675ff7f82f420a461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204374 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927968}
Under LaCros note_taking_helper will exist in Ash-Chrome while the note-taking web apps will exist in Lacros-Chrome. Ash-Chrome will not have access to the Lacros-Chrome Web App registrar so they must communicate via App Service and intents. Also observes updates to apps in AppService so list of note-taking apps is updated dynamically (previously you had to reopen the settings page to see a change after installing a note-taking web app). Bug: 1185678,1194370 Change-Id: I74479d81548c28c54ba65a0dd1f42e46c062c571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3089279 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#927969}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633381085-55cb8527691ae4409bc5778e14d3cd4bbf70689c.profdata to chrome-win32-main-1633391873-45c9634086273e90f89892e12c1b0a03729e397f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I55600bcb919417f1ba7063f73c721a6a3cf25dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204295 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927970}
Moves the SavedDeviceRegistry registration to the mediator. This allows future Fast Pair prefs to be added to the Mediator without causing churn in ash_prefs. Change-Id: I30fa5488be7ef3baf9af76beecde36a0473e52f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194765 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Jon Mann <jonmann@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#927971}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c7d98db..b6c4ca97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia8bb4b0fee613e3adae4eea9523c37e4e7ba67ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203691 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927972}
https://swiftshader.googlesource.com/SwiftShader.git/+log/0625115a7cc2..70178a763bb9 2021-10-04 capn@google.com Refactor swapchain image creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: Icedcef902db80a37d44e11b73d86906ac33a8c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203732 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927973}
ChromeOS test devices (like Android) don't support external files as camera input. Also handling BGRX and BGRA pixel formats. Bug: 1255211, 1206000, 1255674 Change-Id: Ia27948f8538b5de52ea8a94c60a682895e26611f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200631 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#927974}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I31b66c189bd8310ebc78645a7ad399ec9eb96156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204231 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927975}
Seeing failures from calibration waterfall (and fixed by crrev.com/c/3199782). Adding more conversion on the other files in the same folder. Bug: chromium:1252452 Change-Id: I58a25872c8d997f0714a769fbf0d1bd79d6fb8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202582 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#927976}
…erver" This reverts commit 88b35f3. Reason for revert: Appears to be cause of crbug.com/1256617 Original change's description: > Fix the bug made by incomplete frames in Chrome's WebSocket server > > The problem is that if a continuous frame is too long, the WebSocket > server doesn't decord it correctly. > There are two causes: > 1. One is only one frame is included in 'read_buf'in WebSocket::Read(). > 2. The read buffer is increased in HttpServer::DoReadLoop() if the > message is too long. > > To solve this problem, it has to return to HttpServer::DoReadLoop() > every time one frame is read, so the while statement in > WebSocket::Read() is unnecessary. In addition, if the result is > 'FRAME_INCOMPLETE', 'continuation_message_frames_' in > WebSocketEncoder::DecodeFrame() must not be cleared. > > Change-Id: I92e614509a3191b73781e926c811040a27a6fe4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195630 > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Shiho Noda <shihonoda@google.com> > Cr-Commit-Position: refs/heads/main@{#927920} Change-Id: I4b074ec3e25f2c3f2e665d8d3287996e839517ee No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204493 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Darren Shen <shend@google.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#927977}
This reverts commit cbd5685. Reason for revert: Suspecting as cause of flakiness in crbug.com/1256618 Original change's description: > [ntp][modules][photos] Adding metrics for the photos module > > See go/photos-exp-chrome-ntp and Metrics section of go/ntp-memories-eng-design for more details. > > Bug: 1230867 > Change-Id: I550ea79b1f7db3e1af8b09717157471246136a4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195175 > Commit-Queue: Jeremy Selier <jerem@google.com> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927796} Bug: 1230867 Change-Id: I51fe394720be2c5a3874e2c8392553c040e3fd82 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203993 Owners-Override: Darren Shen <shend@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#927978}
This CL has no functional effect. This CL gates chrome app integration for lacros behind a conditional in ash. Ash propagates the value to lacros so that their behavior can be synchronized. This CL adds a kill switch in case we determine that it has to be disabled. The functionality currently remains disabled. When the functionality is enabled, the ash-based chrome app publisher treat all ash-based chrome apps as disabled. Change-Id: I194542049b5bbfa6746c60f4e01ab5733a78402a Bug: 1225848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198698 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/main@{#927979}
Reland this CL with some changes to make sure we publish the QuickOffice extension in ExtensionAppsChromeOs. It has file_handlers and was previously dealt with in FindFileHandlerTasks, so we need to move it to App Service too. CL:3189394 added a test for QuickOffice that fails under the old CL without these changes. This reland also adds some pieces from the follow up CL:3168581 which are actually necessary as there are tests in the tree that rely on them but don't run on pre-submit. Diff from original CL: - Allow QuickOffice in ExtensionAppsChromeOs::Accepts() - Exempt QuickOffice in ShouldIgnoreApp() - app_service_file_tasks.cc pieces from CL:3168581 - CreateChromeAppIntentFilters() pieces from CL:3168581 Original description: Create IntentFilters for Chrome app file_handlers that allow them to show up in GetAppsForIntent() for Intents with files. Add some functionality to the Intent system like matching against directories, which is needed for the include_directories option for Chrome app file_handlers which does not exist for SWAs/PWAs. We add is_directory to IntentFile, rather than try to guess based on URL, because we actually have this information in FindAppServiceTasks() - the EntryInfo for each file has an is_directory field, and this info is from the file system so is much more trustworthy. Change GetAppsForFiles() to accept a list of IntentFiles directly, as we would otherwise need to add an array of is_directory bools anyway, which is getting a bit cumbersome. Move behaviour from IsGoodMatchFileHandler() in file_tasks.cc into FindAppServiceTasks(). This deals with finding the "best" handler within a single app for the given intent - based on product decisions. We can't do this in post-processing because we only return one handler per app. This allows us to return is_generic_file_handler in each IntentLaunchInfo. Ignore all Chrome app handlers with verbs other than "open_with". In Files app, we were already ignoring these handlers and there was no way to see them or use them from the UI. This CL extends that into the FindAllTasks API, which requires changing a few tests which expected handlers for other verbs to be returned. This allows a simpler implementation and has no user-visible effects. Drive-by fix a bug in FilterIsForFileExtensions() where we didn't account for kAction conditions. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 1240018 Change-Id: Ic2df3af1c7737d2ce4fe752c758711e488128b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193930 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#927980}
Also, clears kVariationsCountry in VariationsSeedStore::ClearPrefs(). Minor improvements: * Makes helper functions for checking whether regular and safe seed prefs were cleared to reduce large blocks of duplicate expectations. * Adds some metrics verification to seed-loading tests. Bug: 1205645 Change-Id: I62aefeb8313864e1defcd34a756a5b6c1e77c7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197791 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#927981}
To aid conversions, first removed "using base::TimeDelta;" and converted TimeDelta to base::TimeDelta in the affected files. Then converted all TimeDelta::FromX() and TimeDelta().FromX() (!) into X(). The files in this CL required further manual edits and are thus split into their own review. A subsequent CL will contain all the rest of the above changes. Bug: 1243777 Change-Id: Id99c063de0430939fe5a1e1ab7af9bd73d8970a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202710 Owners-Override: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#927982}
This reverts commit 3bc1f7f. Reason for revert: Breaks video playing on ChromeOS Original change's description: > Choose OzoneBacking over GLImageBacking for CrOS Ash > > This change completes a TODO where the OzoneFactory is chosen over > GLImage since it supports creating shared images with both GMBs and > pixel upload support. It also adds a check for device creation failures > for x11 in ozone and fallbacks to GPU_READ when SCANOUT is not > supported for creating pixmaps. It also fixes null image issue in > SharedImageRepresentationGLTextureOzone. > > Bug: 1241537 > Change-Id: If352cf3efde248ceacb12b64174ed6134749d6f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187214 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org> > Cr-Commit-Position: refs/heads/main@{#927402} Bug: 1241537 Change-Id: I819ea697a89310253a80ee6465927febb045ac13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198022 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#927983}
Bug: 1201569 Change-Id: I76261db820be81219a7681eb4b4cbd6239b5aa1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199160 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#927984}
- Only when true, the RevenLogSource may be included in chrome://system and feedback logs. The flags defaults to false. It should be set to true for the reven board. - The feature flag is kept and changed to be enabled by default. The hardware info is retrieved via the cros_healthd mojo service which could hang in certain situations. Therefore, keeping the flag gives us the flexibility to turn it off when that happens. Bug: b:186631850 Change-Id: I29d0a987fc1368c7503c31a6f9926c6930646939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199705 Auto-Submit: Xiangdong Kong <xiangdongkong@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Xiangdong Kong <xiangdongkong@google.com> Cr-Commit-Position: refs/heads/main@{#927985}
https://android.googlesource.com/platform/external/perfetto.git/+log/6a46cc75169a..8fe04a401754 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I11730f9178c3e6e78f47794f3fd38aba62e690c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204241 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927986}
Change-Id: Ibe92ada4ff5121998fa922d3955b7818cbc66533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204310 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927987}
This CL will add skew tests for version 94.0.4606.77. See crbug.com/1041619 and crbug.com/1099017 for more information. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I498c6bf2f8aed4dfb33d5fe2070878160f29ed6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203152 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927988}
This CL is a no-op as it only adds the code to render the dialog, as well as the JNI bindings, but there is no code calling it yet. 1. Initial state (Progress Bar) Mock: https://screenshot.googleplex.com/og5vUc5cgLZvW2n.png Implementation (Light): https://screenshot.googleplex.com/3wwkKAtWsq8dcpE.png Implementation (Dark): https://screenshot.googleplex.com/3RLAtnrQHnYUWQK.png 2. Success state Mock: https://screenshot.googleplex.com/6ZLTVZAFxTbCTF8.png Implementation (Light): https://screenshot.googleplex.com/UFDhqZDqRavzLUM.png Implementation (Dark): https://screenshot.googleplex.com/AJR4z5uvzJGqf9h.png Bug: 1196021 Change-Id: I22e3d0d28016905c1fddf306f0364002604ee638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3164096 Commit-Queue: Kyle Zhou <kyzh@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/main@{#927989}
When a network error prevents terms of service from loading, the check network button is currently not shown. In this change we show it even on TOS loading failure. We're also resetting the feedback button separator. BUG=b:190714890 TEST=unplug network before TOS loading and verify the button is shown and is functional Change-Id: I6f3a66fe9c9d8b70d11faad0cf2c200954e6eebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203526 Reviewed-by: Long Cheng <lgcheng@google.com> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/main@{#927990}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633381085-b15eb1fa1f8116ecc8dbb0b3bb76dfefb4daa734.profdata to chrome-win64-main-1633391873-5c685df90ba6146ad3ba7e4d3be500a180db4888.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2215326ec9c886aee8ca13a01df80bd523cfdf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204334 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#927991}
Change-Id: Iabceb869127b1b675e6447324ccbe49456ed5383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180497 Commit-Queue: ssid <ssid@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/main@{#927992}
This is a follow up for https://crrev.com/c/3194070 and https://crrev.com/c/3188520 that adds a (missing) (and yet optional) try config for linux-wayland-rel bot and also makes CI and optional CQ wayland bot run chromium_linux_gtests. Failures are not expected as the config is the same as linux-ozone-rel has with the only difference that the bot becomes a Wayland only one. Bug: 1252668 Change-Id: I04eb6dacff3ca8a91bbeacf054e0f6afab071b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198173 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#928025}
Re-enable WebTransportBrowserTest.BidirectionalStream. The cause of the flakiness was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/3198097 BUG=1254667 Change-Id: I4653774c2496eee6b6e6512b6fa8fcc741bcc46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204790 Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#928026}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Ifcfea1b7e4ffeee8e47d8f112d95255992dcdda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204331 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928027}
…eSupported.CacheWhenMediaSessionServiceIsNotUsed Bug: 1253200 Change-Id: I9c1aa5171c333ab7d97b89e0316534ed1d7e7653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198273 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/main@{#928028}
Bug: None Change-Id: Ic48f777bc3369c9dfa832f825ae1a1390def000b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189571 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by: John Palmer <jopalmer@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#928029}
This CL enables the intent picker PWA persistence flag by default. This allows user to store the user selection for PWA in the intent picker. Also the intent picker will auto pop up for PWA, and for preferred PWA the navigation will directly open in PWA. Change-Id: I10b5564664c54e0b296162ef37998f3d3134928c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204413 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#928030}
It was missed that we should record metrics for price drops when calling the Optimization sync API. This CL fixes that. Bug: 1255475 Change-Id: I56f6f6b854882ee2e0739264cf1dc8317f100588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200871 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/main@{#928031}
This CL removes further dice-specific logic from ProfilePickerView, also getting rid of the show_toolbar param for ShowScreen(). Bug: 1248040 Change-Id: Ieda66c07f02f9f3b60930d9f8455e9b6b1d63bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3158229 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/main@{#928032}
Adding support for extra disks when launching borealis via the UI. This is only being used by devs and tests. This CL is also introducing usage of the borealis launch options switch/pref. Bug: b/200903579 Change-Id: I686cf26354fa5180e858d3ba63ecbc5412f41ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189843 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by: Chloe Pelling <cpelling@google.com> Reviewed-by: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/main@{#928033}
…otification As a preparation for upstreaming wpt_internal/prerender/, this CL replaces internals.setPermission() with test_driver.set_permission() as the Internals APIs are not available on the upstream. Bug: 1253158 Change-Id: Icd6fb245f7c7794c25474e3edf7d6e24b523ca43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204073 Reviewed-by: Asami Doi <asamidoi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#928034}
Remove these layouts from settings. For users who are using these layouts, their prefs will store the original layout, but both the settings menu and the IME will default to 2-Set instead. As soon as the user opens the settings, their prefs will be overwritten to 2-Set. Bug: 1239987 Change-Id: Ic5bd29f55b8aa2e74203ec4e75286dc05f07a6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3184061 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/main@{#928035}
This CL cleans up some functions related to the permissionType type update. Note: Couldn't find a way to change the properties from String to permissionType and read from HTML, if there is a way will do further clean up. BUG=1198390 Change-Id: I0866c7fd9879854b7e7c4e6303ac6344397cb5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195701 Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#928036}
https://skia.googlesource.com/skia.git/+log/65e848d6b5ba..c7a55cdcf2be 2021-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from bb417ace110b to 575a198764da (9 revisions) 2021-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2d77db4 to b0f34ac (406 revisions) 2021-10-05 johnstiles@google.com Simplify allowed-in-ES2 checks. 2021-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from a00edc64c486 to b5aafce0db45 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I481a37858beb0a63e92719681cdb731a848e00c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204245 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928037}
Make a dark mode theme color that SWAs can set. This lets an SWA specify a startup theme for dark mode so that the webcontents starts in the correct background, and there's not a blink as resources are loaded and the titlebar changes. Bug: 1237527 Change-Id: If22855b06dea5caaef297db5f692946f1ae416a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189390 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/main@{#928038}
setup system xcode for re-client as goma client Bug: b/202087825 Change-Id: I40e4cb044393dfe28c967c07d7a1421bbd72fede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204810 Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com> Cr-Commit-Position: refs/heads/main@{#928039}
Bug: webrtc:10739 Change-Id: Idf2a76f8f58bb3c6163473b76428fb9b0b144f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202310 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Minyue Li <minyue@chromium.org> Cr-Commit-Position: refs/heads/main@{#928040}
WebLayer's SafeBrowsingBlockingPage creation flow has code in it that handles the case where the URL passed in is empty. I had previously noticed that this differed from //chrome's flow, which doesn't have any such code. However, at that point I was doing refactoring and looking to avoid any behavioral changes. I have since investigated and discovered that this code dates from the initial addition of committed SB interstitials to WebLayer: https://chromium-review.googlesource.com/c/chromium/src/+/2003857 It looks like it was likely ported from the analogous code in Android WebView's implementation of safe browsing interstitials at that point: https://chromium-review.googlesource.com/c/chromium/src/+/1872945 (see aw_safe_browsing_blocking_page.cc:132-135 in that CL) However, that CL has a helpful comment stating that the logic is only for handling non-committed interstitials and can be removed when non-committed interstitials are removed. As WebLayer uses only SB committed interstitials at this point, this CL removes the unneeded logic from WL's SafeBrowsingBlockingPage creation flow. Bug: 1248408 Change-Id: I3f62bca12b292a30e14f77f33758600d90b0dc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202193 Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#928041}
Roll Chrome Mac PGO profile from chrome-mac-main-1633391873-479cd943e27249bc9be149ef0ae8072d8163aa9d.profdata to chrome-mac-main-1633413357-8d6c393c75db4dbbae1fb957c5485260c6a320eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I155d385ab5cd34b7e02c89f8ba35247173c1742d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204307 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928042}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b536e721e92..ba7ad68232ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1234080,chromium:1252124,chromium:1255750 Tbr: shend@google.com Change-Id: I46a098cb4390a87967893c72bc7a8a63ef479b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204724 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928043}
OpaqueBrowserFrameView has been exposed with the accessible role of TitleBar even though this view holds much more than a title bar. An accessible title bar role is typically just the bar with the title and possibly widgets to resize the window. Also accessible title bars are not expected to be ancestors of the web document, which is now the case due to crrev.com/c/2780032. This commit changes the role from TitleBar to the more generic role of Pane to eliminate confusion regarding the expected size and contents of this view. Bug: 1255072 Change-Id: If3d3b4c3d93900028389a905f1f7b059cec06142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198075 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/main@{#928044}
Currently, when a parent frame creates a new subframe, we look through the list of proxies in the parent's FrameTreeNode and create a set of proxies in the same SiteInstances in the new subframe's FrameTreeNode. This turns out to be problematic if the proxy is in a different BrowsingInstance, which turns out to be possible if we have started a main frame navigation to a different BrowsingInstance, and before it commits, the current (old) document adds a new subframe. In particular, creating that proxy on a subframe FTN means that the proxy may get preserved if the old document is stored and later restored from BackForwardCache, leading to crashes when we try to use that proxy while assuming it's in the same BrowsingInstance, such as if the subframe creates another subframe. More concretely, consider the following example. Suppose A starts a navigation to B. This goes through CreateProxiesForNewRenderFrameHost, which creates a cross-BrowsingInstance proxy in the main frame's FTN, because all speculative RFH navigations must always start with a proxy that will be replaced by a real frame on commit. Note that we intentionally skip subframes of the navigating frame in this code, so while process B will have a proxy for the main frame, it won't know about any subframes that A might've had before the navigation to B started. Next, suppose A adds a subframe A2 before the navigation to B commits. Presently, this copies all proxies in A's FTN to the new A2 FTN, *including* the cross-BrowsingInstance proxy for B. This is incorrect: the new process doesn't need to know about the new subframe, just like it didn't need to know about A's subframes when the navigation started. There's still a safeguard in that if we allow the proxy to be created, it would normally get cleaned up as part of Frame::Swap(), when detaching the old frame's children when the navigation commits, but unfortunately it's possible to bypass that safeguard by racing the commit IPC with the proxy creation IPC, in which case the cleanup won't happen. In that case, A2's FTN would keep the proxy in B's process, and if A went into BFCache and was later restored, A2 would still have that proxy. If A2 now creates another subframe A3, we will try to inherit all proxies from A2 to A3, but this will break a bunch of our assumptions (namely, that subframes are in the same BrowsingInstance, and that a subframe proxy implies that a corresponding RenderViewHost has already been created), which leads to a crash. To fix this, we modify CreateProxiesForChildFrame to skip over proxies in a different BrowsingInstance. Bug: 1243541 Change-Id: If9fe89302c5338ec83549e8827611e8e7f3c6525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203096 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#928045}
Roll Chrome Linux PGO profile from chrome-linux-main-1633391873-f6f556d2fafbf395d3f75b48642d17f5e1c98a7f.profdata to chrome-linux-main-1633413357-c1abce3cb781315eeb6bcc70a7bce0f370025b8d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie99df3bde2a14f3c0a5ff2d027f13630a7d3605d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204145 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928046}
Bug: 1251576 Change-Id: Id71b3306efe683716a72a1a51408dd4d51ef09b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202095 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/main@{#928047}
If max-block-size is specified to a <fieldset>, its content box block size should be limited to <max border-box block size> - <border block size> not <max border-box block size> - <border and padding block size> because padding is delegated from the <fieldset> to the content box. Bug: 1247733 Change-Id: Iac7bc0885b4d8989309ced64b7902f5476c4383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204791 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#928048}
The lock screen can show a SAML reauthentication dialog. If this happens, allow usage of system slot client certificates there, with the same restrictions as apply for system slot client certificate usage in SAML flows on the sign-in screen. Note that this does not add support for smart card provided certificates on the lock screen - that is tracked in https://crbug.com/1255676 . LockscreenReauthDialogTestHelper has been introduced to hold shared functionality for testing the lock screen re-auth dialog. It is used by existing SamlLockscreenBrowsertest and the new browsertest. Bug: 1252678 Test: New browsertest Change-Id: Ic12ba218de3f436a8f55d4f3873455e5123b9e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193015 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/main@{#928049}
The viewport-segment-* set of environment variables are two dimensional, i.e. you need an x and y values in order to access them. This change adds support for such environment variables to CSS parser, style resolution and the StyleEnvironmentVariables class. The variable values are stored separately in a two dimensional vector, and new methods that explicitly operate on two dimensional variables (via an explicit enum) have been introduced. Additionally, this CL converts the previous fold-* variables to the new viewport-segment variables with the indexed syntax. Bug: 1039051 Change-Id: Id520ee47f4c9bd79bc47ee1693c80750f2a8779b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195791 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#928050}
It seems like data-URI background image SVGs are not considered as LCP candidates at the moment, and they should be. This CL fixes that. Bug: 959296 Change-Id: Ie195b7a03c118e4103ba88948db5a7bc338b51ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3197729 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/main@{#928051}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/753b8ed4ff96..ec40026704a7 2021-10-05 alexrudenko@chromium.org Implement an icon for experimental/preview tabs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If96d3adfdb87e136f3eb2b255f9599eba419e33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204525 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928052}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )