[pull] master from chromium:master #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://skia.googlesource.com/skia.git/+log/eda5ba159815..90c86ad06cf3 2021-10-18 johnstiles@google.com Report an error when negating or plussing an array of scalars. 2021-10-18 fmalita@chromium.org [skottie] Fractal Noise: cycle evolution support 2021-10-18 johnstiles@google.com Allow vector operator~ in SkSL. 2021-10-18 michaelludwig@google.com Experimental support for lower-resolution backdrop filter eval 2021-10-18 johnstiles@google.com Add error test for unary-negating and unary-plussing arrays. 2021-10-18 johnstiles@google.com Allow const int variables to be used for array sizes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I07c78360718f23a5434f38f74f271c17f2f396f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229683 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932588}
Migrate oobe-i18n-dropdown to ES6 class syntax and add directives to generate its modularised version. Bug: 1184731 Change-Id: I0b11d29ba3253aaa7846fd35d482e96f45a4a866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220301 Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/main@{#932589}
According to UMA dashboard, there has not been a single sample recorded for these histograms since milestones 58 or 53. Code search does not find the histogram names in the source code either. These histograms have apparently been removed a long time ago. Change-Id: I1dac651118b284f80680c571b7e9636fd1e265d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3189334 Reviewed-by: David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/main@{#932590}
This change moves the feature check from backend_factory to the ProxyBackend. The sync status is checked before the feature check to limit the experiment to syncing users only. Bug: 1256765 Change-Id: I495f55785567262dd572ff9e8c735b16654e9c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226066 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#932591}
This reverts commit 54738b8. Reason for revert: Likely cause for tree closure from this build: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac%20Builder/146453/overview Original change's description: > Enable -Wunused-but-set-variable. > > Bug: 1203071 > Change-Id: I5e82348074c2a06392595cf22aadfb1157040689 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228315 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/main@{#932587} Bug: 1203071 Change-Id: I0cd344a69bfeb33b60a7dbbcb4a89f763b93d8a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229674 Auto-Submit: Emily Shack <emshack@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by: Emily Shack <emshack@chromium.org> Reviewed-by: Guillaume Jenkins <gujen@google.com> Owners-Override: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/main@{#932592}
All relevant backing should support Overlay representation by now. Change-Id: I0f06a6e9641c3e5c5c056d7f7111a26494894342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225866 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#932593}
Otherwise, this saturates the ash crash repoter queue, which prevents different crashes from being uploaded. Bug: 1090134, 1260112 Change-Id: I92d27ee4b9d4d5967829769ea3de97920a0e550f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225957 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#932594}
Looks like "-J" flag no longer exists. It was there to enable gzip on upload, so works fine without. Change-Id: I50159396edc27319fd9ce29f76c05985ff8d3e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227161 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#932595}
fix a crash occurring in the function. There is currently a crash occurring in AXNode::GetUnignoredParent when the function does unignored_parent->IsIgnored(). We have two hypotheses for why this may be occurring: 1. The tree update is currently in progress. 2. The data is missing; i.e. TakeData() was called and data_ was released. To confirm this hypothesis, we are replacing a DCHECK (which is not called in production) with an if return. Before returning, we dump some additional information which will be useful in understanding why the function is called at an unexpected time. Bug: 1237353 Change-Id: If241ad9fc183bc0799a880f4e9909097078310a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216499 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/main@{#932596}
Find myself can not approve some of the wpt-importer/exporter related change, which is inconvenient Change-Id: Ifbfb269ca8edea51f34844136c4733dd53dc059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229532 Auto-Submit: Weizhong Xia <weizhong@google.com> Reviewed-by: Rakib Hasan <rmhasan@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#932597}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba25ddde1df6..11bc35c1c540 2021-10-18 szuend@chromium.org Add SettingCheckbox component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1245541 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If425c58f062995a73d22e11a119f3c8b0fd03f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229684 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932598}
Fix the remaining incompatibility and unit test Bug: 1254879 Change-Id: I3d6b62e37545c13bc57eb46c0e4f9760ed8b3aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229665 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#932599}
The changes in patchset#1 are associated with CL crrev.com/c/3166650 that was reverted due to the crash reported in the linked bug. This CL attempts to reland these changes after updating the following: - Add null checks for the SnackbarController in SnackbarCollection methods and add a related unit test to guard this change - Pass a null SnackbarController input in ChromeActivity#onIntentCallbackNotFoundError and add a unit test to guard this change Bug: 1258303 Change-Id: I3fa21d3cc19ce2e458279f8cc179b496f76f5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216527 Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/main@{#932600}
Bug: 1260365 Change-Id: I6a0b5484f8d8bced577c7d6c317614fca4298589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229662 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#932601}
This CL introduces an Origin Trial for "AutoDarkMode", which recently was approved on the following blink-dev thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/E29o9uJ8VRs/m/oKi03ed_BAAJ Auto Dark Mode is a bit of an outlier, as it builds upon the identically named feature for Android WebView that was implemented as a Blink Setting as opposed to a RuntimeEnabledFeatures. This setting already has been hooked-up throughout the CSS, graphics and style systems, as well as DevTools for a developer-focused toggle. In order to support this, OriginTrialContext has been amended to be able to install binding features as well as settings features, while carefully making sure that the latter do not cause additional V8 processing. A test has been added for this behaviour. Bug: 1258615 Change-Id: I71567a7aacf25312e56999278ed4d13af8781944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217643 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Jason Chase <chasej@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#932602}
The Input MVP bot is broken now, so don't run it for rebaseline now. Bug: 1260950 Change-Id: Id88c914087e7e69b96d9850b2e83567fb20cad3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229667 Auto-Submit: Weizhong Xia <weizhong@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Preethi Mohan <preethim@google.com> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#932603}
Bug: 1260154 Change-Id: I9736cec2097accf29b1466c1e120d1e119370425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229861 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/main@{#932604}
Screenshots: https://screenshot.googleplex.com/G7mDKdVMjQFTksc Bug: 1260063 Change-Id: I9b2fe3d679c3bc3d01f792749bc8330f3bf56fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223161 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/main@{#932605}
With the addition of the new global media controls component, we now have two different grdp files named global_media_controls_strings: components/global_media_controls_strings.grdp and chrome/app/global_media_controls_strings.grdp This CL renames the chrome/app one to gmc_strings.grdp Bug: 1260955 Change-Id: I2a974f0ea1cc3944d040416c3e02f1633390f505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229529 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/main@{#932606}
Bug: 1259929 Change-Id: I658d8b65d722b40b6f01cc99f3d78d74debbb09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222748 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/main@{#932607}
This reverts commit a0cb006. Reason for revert: Fixed the use-of-uninitialized-value error in test. Original change's description: > Revert "[Coupon] Add rate control for FLC bubble" > > This reverts commit 5640d8c. > > Reason for revert: Tests failing in linux MSAN bots > > Original change's description: > > [Coupon] Add rate control for FLC bubble > > > > For FreeListing coupons, we don't want the infobar bubble to show at > > the same frequency as GPay CLO offers. Instead, we want to limit > > it to show once per day per domain, and only show the omnibox icon for > > other times. This CL implements this rate control mechanism. More > > details can be found in the doc in the bug link. > > > > Bug: 1256989 > > Change-Id: I734a672a6c514ead79bc1545a54dacb5d281de6c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212647 > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#931743} > > Bug: 1256989, 1260238 > Change-Id: I24f91601b0623056a0b829b190ef73cf5a281438 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225340 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Owners-Override: Rakina Zata Amni <rakina@google.com> > Cr-Commit-Position: refs/heads/main@{#931854} Bug: 1256989, 1260238 Change-Id: I4f910de1e44fde21d0b2d8fbe8d70532338a5f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225142 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/main@{#932608}
When ECH is rejected, the server handshakes with ClientHelloOuter, which will result in it sending a certificate for the public name. ECH uses this to recover from mismatches between the DNS and server. If the certificate is good for the public name, we can extract an authenticated ECH config (or lack thereof) from the connection and retry. This CL implements the SSLClientSocket APIs needed to support this fallback flow. The actual retry will need to be implemented a layer above, in SSLConnectJob, once the fields from the DNS bits are ready. Some notes: - I've opted to make certificate errors in the fallback flow unbypassable by mapping them to some generic fatal error. This matches our behavior with HTTPS proxies and DoH. Otherwise we need to work out plumbing and UX to ask the user "as part of connecting to example.com, we need to verify a cert for this random unrelated name... is this certificate okay for that?". That seems absurd. - There is a bit of a mess between DNS names vs. IP addresses, layering between BoringSSL and Chromium, and the very complex WHATWG URL syntax. Due to how our CertVerifier interfaces work, we need to worry about misinterpreting a DNS-name-typed string as an IP address. This mess is much simplified after https://groups.google.com/a/chromium.org/g/blink-dev/c/7QN5nxjwIfM/m/EBWRCH71AQAJ but, out of caution, I've added a redundant IP address check, using our actual URL parser. (Although, to be honest, the consequences of misinterpreting this aren't that bad.) - I've made the error codes say just "ECH" without "SSL" because the QUIC half will need to participate in the same logic. ("SSL" is about as inaccurate for TLS/QUIC as it is for TLS/TCP these days, but we currently refer to TLS/TCP as "SSL" in code a lot, while we don't do so for TLS/QUIC.) - I've given the Chromium error codes slightly different names from the BoringSSL ones, which maybe suggests we should rename them there and in the spec. The reasoning is our error codes end up in user-visible net error pages. While the spec uses terms like "ECH rejected" and "handshaking with ClientHelloOuter", those seem slightly confusing. I've used "ECH not negotiated" and "ECH fallback certificate". (Much of this was partly my fault in the spec, so I only have myself to blame here. :-) ) Bug: 1091403 Change-Id: Iaee9c92752f2559015f68cd34a8d99b92dac66eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216115 Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Chris Thompson <cthomp@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#932609}
PasswordManager may classify sign up flows that consist of a single username form and a single password form as username first flows (even if the password is correctly parsed as an account creation password). To avoid filling username into a sign-up username field, voting on sign up forms should be stopped. Bug: 959776 Change-Id: I45b4884c1be003a67f74c3f6459896923249d181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226402 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932610}
- Add `kIconlessAccentFloating` type of PillButton, which is `kIconlessAccent` without background. - Apply this type to the button in system toast. Take a look of the toasts after migration at crbug/1258935#c4 Bug: 1258935 Change-Id: I5be76b1ccadbb94d3424a230b5501d243c1e15f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227469 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/main@{#932611}
The affected test suites are: * webkit_unit_tests * MediaStreamAudioProcessorTest.StartStopAecDump * base_unittests * FileUtilTest.FileToFILE * IcuUtilTest.InitializeExtraIcuFromFdSucceeds * ModuleCacheTest.CheckAgainstProcMaps * ProcessMetricsTestLinux.GetPerThreadCumulativeCPUTimeInState The same tests failed on android-11-x86-rel so rename the filters and share them with two builders. Bug: 1188310, 1260521 Change-Id: I41b36a8d5311a8031970b26d083b13457e566004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227618 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/main@{#932612}
This is a reland of 0abd076 See patchset 2 for the fixes for crbug.com/1260818 Original change's description: > Reland "feed modularization: FeedStream" > > This is a reland of 70331b9 > > Original change's description: > > feed modularization: FeedStream > > > > * Moved several other classes to the module > > * Introduced FeedActionDelegate to delegate some actions > > out to the app / containing surface. > > > > Bug: 1254437 > > Change-Id: I1dce3a37c0c1d2a1ac37b54e519e0100ee78256f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221891 > > Commit-Queue: Dan H <harringtond@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Xi Han <hanxi@chromium.org> > > Reviewed-by: Cathy Li <chili@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#932242} > > Bug: 1254437 > Change-Id: I5c77efa19a5b8afd04e96dce4dac6b10144be0cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227720 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/main@{#932387} Bug: 1254437 Change-Id: I1466075585e41f4a2e50cced1819c398c352e2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229454 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/main@{#932613}
This is a reland of 540f418 Change on reland: normalize title of about:blank targets Original change's description: > Implement AuctionWorkletDevToolsAgentHost > > This is a sibling CL with https://chromium-review.googlesource.com/2953363 > > Bug: 1209620 > > Change-Id: Ifa05b6fb338d2d7c5b2713d1e84d41ee4a6fc21d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3067509 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Maksim Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/main@{#932118} Bug: 1209620 Change-Id: I7fd754736e9a4723e5fd73b4f370fbfa55ff22ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227559 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#932614}
Bump histogram expiration by a year as it will continue to be useful. Bug: 1261106 Change-Id: Ibac3d7c7973b7cfb213c3b046234437d5be71e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226825 Auto-Submit: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/main@{#932615}
For the PDF Viewer, find-in-page should only return results from the PDF content, and not from the PDF Viewer's UI. In the PPAPI-based PDF Viewer, the renderer process that hosts the UI has a blink::WebPluginContainer, and deferring find-in-page operations to that WebPluginContainer really defers to the PDF plugin. In the PPAPI-free PDF Viewer, that same process just hosts the PDF renderer and has no plugin to defer to. The PDF renderer has a blink::WebPluginContainer instead. With no plugin to defer to, the renderer running the PDF UI performs find-in-page on its own contents. To fix this, avoid creating a content::FindInPageClient for the RFH with the PDF UI. For content::FindRequestManager to make this decision without direct knowledge of the PDF Viewer, add a generic ContentBrowserClient::IsFindInPageDisabledForOrigin() interface and override it in //chrome. Along the way, add some getters to FindRequestManagerTest to retrieve commonly used nodes in the FrameTree, and use those in both new test cases and to simplify existing test cases. Bug: 1199999 Change-Id: I85dddd90bd4a6a57ba84e3ba8f7c09bdd99bd17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229023 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#932616}
- Adds the fetchGifForUrl method to the LR mediator, which uses the ImageFetcher to download animated GIF assets and return them as BaseGifImage instances. - Adds the fetchAssetsAndGetThumbnails method to the LR mediator, which takes the list of metadata for the available reactions and downloads the thumbnail and the animated GIF for each of them. Only the thumbnails are returned, since they are needed immediately for the toolbar. The GIF assets are not used, but by fetching them, the ImageFetcher will ensure they are cached on disk, which will let the LR dialog access them almost instantly when they are added to the scene. - Hooks up the fetchAssets method to the coordinator constructor, and temporarily asserts the returned thumbnail list looks valid. Bug: 1259237, 1259239 Change-Id: Ibf20a49b5e4d953103bcc8abf13fcdfd23d95447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225865 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/main@{#932617}
https://swiftshader.googlesource.com/SwiftShader.git/+log/33eaf1f76b60..95b769124656 2021-10-18 srisser@google.com Update Vulkan headers to version 1.2.196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-eng+autoroll@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-eng+autoroll@google.com Change-Id: I0f1c25a908e26f5344a97bb151e405b276fa70f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229870 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932733}
This reverts commit d0c1b5d. The default minimum SDK version is controlled by a GN arg, and used whenever a target does not specify the SDK version. Bug: 1255748 Change-Id: Iff2ed63f73f1588124962c2f72886b71a450fbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228368 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#932734}
This CL updates the tab helper to call NotifyUserActivation() on the current page in the tab frame when opening a new page in the tab frame from the side panel. This is done to prevent the current page in the tab frame being incorrectly marked as skippable. Currently this can happen when the user opens multiple links from the side panel without interacting with the page that has been opened as they do so. The ensures we meet the user's expectation that pages present in the tab frame correctly participate in back/forward navigation as they interact with the side panel. Bug: 1259196 Change-Id: Icf8b85ca61a95423940c9df4b9fad585a16dcd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223985 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/main@{#932735}
This CL deflakes OmniboxTest#testSecurityIconOnHTTPSFocusAndBack and re-enables it. The issue was that the back button event was sometimes generated before the EditText widget is ready (or while temporarily not ready yet), therefore gets lost. This could be verified by giving enough delay (as much as 5000ms), which makes the problem disappear. Interestingly this happens only on the emulator running with --avd-config=tools/android/avd/proto/generic_android28.textpb. Not observed on other config or on real devices. But there was a much bigger problem that made the test very flaky: Espresso ViewActions#click has a bug. For this specific test, roughly 1 out of 50 times, |onView(withId(R.id.url_bar)).perform(click())| generated a long click instead of a click. This caused the text selection to be activated on the EditText widget. Back press was only consumed to deactivate it but failed to make the URL bar lose focus and get the security lock icon back. It is a known issue documented in the Espresso repo: https://bit.ly/3BHMhEC Found from here: https://stackoverflow.com/questions/32330671/android-espresso- performs-longclick-instead-of-click This is allegedly a very hard problem to solve. The approach taken in this CL to work around it is to replace Espresso APIs with a test util method that can work to the same effect of click()/backPress() by giving/taking way the focus from URL bar. Bug: 1195124 Change-Id: Ic5d98760334d55f70e99ed03b4de5560573a0d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220763 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/main@{#932736}
Bug: 1188290 Change-Id: I46401ac5cd8ffa97b93c7b67eefd707f0f00bc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179275 Reviewed-by: Chris Thompson <cthomp@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/main@{#932737}
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/198699532a52..025086bfe75e 2021-10-18 phosek@google.com [CMake] Cache the compiler-rt library search results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libcxxabi-chromium Please CC thakis@chromium.org,hans@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,hans@chromium.org Change-Id: Ia919340a6e78fb8a4a2b8222a04133a889092ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230187 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932738}
This is just some general cleanup ahead of adding shortcut stuff. Change-Id: Ie0a786199ba3ed9c0ce28fb3e27c1951a9f458b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3221289 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: David Pennington <dpenning@chromium.org> Cr-Commit-Position: refs/heads/main@{#932739}
Roll Chrome Win32 PGO profile from chrome-win32-main-1634579960-218fd0a28a6d3fea1732eea272be37b0c4f7ec5f.profdata to chrome-win32-main-1634590785-38f93fca19b57ee06348841dd6682f6bb90f1200.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icf34399ccee994d63a63cd97365b0b56b8809acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230188 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932740}
Android L (lollipop) is being deprecated, so remove this ci bot. Bug: 1255748 Change-Id: I8cd559d52fd307206388f1c6dc08dfae6b7bb07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230167 Reviewed-by: Haiyang Pan <hypan@google.com> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ben joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/main@{#932741}
These typos were found while working on the associated issue. Fixings then in a separate CL, to avoid confusion. Bug: 1248117 Change-Id: I100485c9f00c47493aed1b0c50bd464e7e95346f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220617 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/main@{#932742}
Roll Chrome Win64 PGO profile from chrome-win64-main-1634579960-ee978ff0f6f3838b09b2c4b12afe8b64f0739876.profdata to chrome-win64-main-1634590785-6362c1537cb82f123f4d5ab9b33d03f06b03fd75.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2ad32a9d40eefa640710bab562a5a80d4f1bfee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230189 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932743}
1. Add a flag to override time limits for running Segmentation models. 2. Run the dummy segmentation model at startup if model is available, and report the results to UMA. This also creates the segmentation platform service by default at startup. 3. Fix a crash caused by profile manager destruction. The profile destruction can happen after the manager. 4. Add logs to the platform code for debugging models with Chrome locally. BUG=1261131 Change-Id: I314b6cc7acea5784ea6479f160b3542f15784995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219383 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/main@{#932744}
Makes the "focus help bubble" accelerator work; hotkey is ALT+SHIFT+H on PC/Linux/ChromeOS and CMD+SHIFT+OPTION+H on Mac. Unlike F6 which immediately focuses the IPH bubble and then does nothing, this accelerator focues the help bubble and then focuses the item the bubble is pointing to (if it is focusable). If the target element is not focusable, behaves the same as F6. Follow-up items: - screen reader help message appended to help bubbles to announce focus help bubble shortcut - gate help message so that it is only announced a limited number of times and stops being announced if the user uses it enough times Bug: 1212149 Change-Id: Ifedce82437f4e609c6ebf9bdce64aa21060f9cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3207296 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#932745}
Updates the expiration of histograms with approaching dates, and transfers ownership to people on the cross-device team where needed. Bug: 1261087 Change-Id: I25de53ba7f25e4b9f4b0a67260cb30c958340f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229838 Reviewed-by: Josh Nohle <nohle@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/main@{#932746}
add additional_compile_targets to match with ios15-sdk-simulator Bug: 1259004 Change-Id: I65b81c4f5ba004b4351b1e0b058fd5c34411a520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229183 Commit-Queue: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Michael Savigny <msavigny@google.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#932747}
https://skia.googlesource.com/skia.git/+log/90c86ad06cf3..8fafb0f6337e 2021-10-18 csmartdalton@google.com [graphite] Add setters to Rect 2021-10-18 brianosman@google.com Disable GL_NV_shader_noperspective_interpolation on PowerVR 2021-10-18 jcgregorio@google.com Restore Android NativeFonts bot coverage. 2021-10-18 jvanverth@google.com [graphite] Add command buffer test 2021-10-18 bungeman@google.com [pdf] Treat dc:creator as rdf:Seq 2021-10-18 fmalita@chromium.org [skottie] Fractal Noise optimization If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: Ibdd8c0118e53a90dcbf01d443d16487b92fc8038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230192 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932748}
Fix unsequenced (in C++14) move/use of a variable, found by the "bugprone-use-after-move" clang-tidy check: fake_connection_manager.cc:61: 'update' used after it was moved fake_connection_manager.cc:61: move occurred here the use and move are unsequenced, i.e. there is no guarantee about the order in which they are evaluated Bug: 1122844 Change-Id: I80938e8d9dda47698a27a74a09279de22a68cbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228229 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#932749}
Duplicate configs to feature_configurations file. Bug: 1238900 Change-Id: Ic9d444f9a3ed8b5cf55b489a62fed00c060ef168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229970 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/main@{#932750}
…put method. In the past, the extension is guaranteed to receive all updates to the input method options whenever they change. However, with system PK, the extension may not be running when the user changes the settings, so they may miss an update and have the incorrect settings synced to localstorage. To fix this, always send an input method options update whenever we activate a new input method on the extension. This ensures that the extension will query for the latest options. Bug: 1257912 Change-Id: I92b3d8c3f116275bfdeb7618255553829deb421b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220902 Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by: Jing Wang <jiwan@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#932751}
out/Default/browser_tests --gtest_filter=EcheAppUIBrowserTest* Bug: b/191410358 Test: autoninja -C out/Default chrome browser_tests && Change-Id: I752e4ad61a8c7af02a848c197cff29f3bcc7be9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218839 Reviewed-by: Daniel Nishi <dhnishi@chromium.org> Commit-Queue: Paulz Chen <paulzchen@google.com> Cr-Commit-Position: refs/heads/main@{#932752}
JS code seems to be explicitly looking for string that was updated to a new one so the Dawn features list was being rendered as if they were toggles. The fix just updates the hard-coded string that prompts the state change. Change-Id: I29cbc6003812e2cda1e1bb862b7e03a613667fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223514 Commit-Queue: Loko Kung <lokokung@google.com> Reviewed-by: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#932753}
Update StoreClient from a behavior to a mixin. In the process, avoid extending StoreClient from cr/ui/store_client.js, which cannot be updated to TypeScript yet as it is used by a few Chrome OS UIs. Merge the cr/ui/store_client.js behavior with the bookmarks StoreClient behavior. Bug: 1189595 Change-Id: Ie4d73b180edab32861672d7927f8b720b5ef199c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225005 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#932754}
TabSearchFuzzySearch flag Previously, we use the value of searchThreshold to determine whether to perform fuzzy search with fuse.js(searchThreshold > 0) or our custom exact search function(searchThreshold == 0), which is unintuitive and makes turning on fuzzy search complicated. This CL checks the TabSearchFuzzySearch flag directly to determine whether to use fuzzy search. After this CL we can simply enable fuzzy search by adding --enable-features=TabSearchFuzzySearch. Bug: 1099917 Change-Id: I30ecf9cbb399d4f163e117e08cc2b08128142518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226756 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by: Roman Arora <romanarora@chromium.org> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/main@{#932755}
This CL adds some logic to switch the colors of the primary and preview focus rings of Switch Access on ChromeOS while recording a macro. We add Material red colors and toggle the focus ring colors during the action recorder start and stop methods. AX-Relnotes: N/A Bug: 1258921 Change-Id: I64638a1935ceb3d7667c54f9e988a6ca7a822a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227525 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/main@{#932756}
This matches the spec after WICG/close-watcher#8. Note the outstanding question at WICG/close-watcher#7 about the Esc key; since Chromium currently does not count the Esc key as user activation, we have one particular behavior. The tracking of last user activation time ensures that any user activation allows the CloseWatcher to, in the future, fire a cancel event---not just during the transient activation duration time window. This gives the desired semantics outlined in https://github.com/WICG/close-watcher#asking-for-confirmation and https://github.com/WICG/close-watcher#abuse-analysis. Bug: 1171318 Change-Id: I34212f29539d5796b4a9bdc4c7351b9d8ea5880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3168969 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#932757}
Also refactor common data into a fuchsia_telemetry_test_data group. Fixed: 1260653 Change-Id: Iabd63ad0412fe31354b623e5a49680164db3957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3228316 Commit-Queue: Chong Gu <chonggu@google.com> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#932758}
Added strings to use in the upcoming settings page for HPS notify. At present they shouldn't be translated since the strings themselves have not been finalized. However it is useful to submit the working strings to allow for idiomatic settings page development. When the strings are finalized, we will update them here and go through the best-practice process of uploading translation screenshots. The prototype UI from which these strings are taken can be seen at: https://docs.google.com/presentation/d/1v-yso6EkTCitvW_K_ozmaybDdv6nhuXoLSjsVwxgfpY/edit#slide=id.gd8ce9d751f_0_0 See go/cros-hps-notify-ui-impl for feature details, and go/cros-hps-oss for naming conventions. Bug: chromium:1241704 Change-Id: I089d89b11cfbf65e8a2e1e7ea917d89d88aaf746 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226009 Auto-Submit: Michael Martis <martis@chromium.org> Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/main@{#932759}
complex tutorials require hidden steps. The "must_remain_visible" option is added from InteractionSequence::Step to support kHidden steps. Change-Id: Id90f49ad605c1dd9049ef9d96ca48e09c68c4711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183021 Commit-Queue: David Pennington <dpenning@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#932760}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )