[pull] master from chromium:master #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This CL adds a basic browser test that verifies the "getSyncInformation" works as expected when called from JS in the DevTools window. Drive-by: Pipe the "Profile*" argument through when creating the DevTools window. The sync test infrastructure uses separate profiles from the default ones. This CL is part of a chain: 1. https://crrev.com/c/3217452 adds the binding in the backend 2. https://crrev.com/c/3217093 adds the binding in the frontend 3. https://crrev.com/c/3217454 adds a test for the backend CL The test only works after 2) has landed, so we need to land it separately. Bug: 1245541 Change-Id: I7933df5584e60da3b4738bff2d4ae8efe9c6a04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217454 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Wolfgang Beyer <wolfi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#932881}
https://skia.googlesource.com/skia.git/+log/99f23a03098f..0c0ccc985e94 2021-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 180ec459ea79 to 40b73c646e2d (4 revisions) 2021-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bea0013 to 26d05ef (433 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I5ac6605abb406eafc3b71e4c551f42af2d32db57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230570 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932882}
https://android.googlesource.com/platform/external/perfetto.git/+log/8ab5ebb4f40c..f09923e0f459 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idc5d8510578c7204e2b1deb64479fc575fc172f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230622 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932883}
This CL has no user-visible behavior changes. Bug: 1259085 Change-Id: I2d85f48d937b183276c00dd092f515ccc9035a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229281 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#932884}
This change removes the use of 'ListValue::GetDictionary()' in chrome/browser/ash/file_system_provider and replaces it with Value::GetList()[] followed by Value::is_dict(). Bug: 1187091 Change-Id: I90ec6db4cc8ab3ed43290fb90b7e11ba2e1954f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199527 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/main@{#932885}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in goldctl (mac): https://bugs.chromium.org/p/skia/issues/entry?owner=kjlubick@google.com To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2210f7a15da9a8c35998f85cfb39da19762ebd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230263 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932886}
Test: unit_tests Bug: 1251873 Change-Id: I2eb7f7dd86e2b008cd3b607e224c058124e4d450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229341 Reviewed-by: Tony Yeoman <tby@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/main@{#932887}
This histogram was used for investigating searches with extremely long query lengths, but the issue has been resolved and this histogram is no longer used. Bug: 1249075 Change-Id: I53acf94b839e804b7c2a188c46f956000678ba9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230661 Reviewed-by: Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/main@{#932888}
… detected Remove the no document detected code path and use fixed initial guess for crop area select page when no document corner detected. Bug: b:203028477 Test: tast run <DUT> camera.CCAUIDocumentScanning" Change-Id: Ib98819411710f522b7ccb055092db9d147a02962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3224961 Reviewed-by: Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/main@{#932889}
Roll Chrome Mac PGO profile from chrome-mac-main-1634601476-d2d25ba952dd1f1f525c84d450f0b538c8826423.profdata to chrome-mac-main-1634623137-22bcd85ae071fdc0f845da5accd6d9c40a76bed0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie26e4c2153e9939c1f9b31e88899e6fbba4cc459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230593 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932890}
This CL updates the ash version 96.0.4664.9 for Lacros version skew testing. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Ie101ae0e00b91ffa6f327f2b055f9d4766be55cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229703 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932891}
Roll Chrome Win64 PGO profile from chrome-win64-main-1634612043-1609650b5d6801628dbcf475f95316686995e015.profdata to chrome-win64-main-1634623137-0cbab184edf7918c16943a721d8131a2879c41d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iec108df106244f03b91f02e4f005684442426066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230838 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932892}
This is required to remove the dependency on ash in preparation of making one of its users available in Lacros Bug: 1251490 Test: Everything still builds Change-Id: I7600c10bf2a08b3dd6c3f59a09c3b532fd46b674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222942 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Toby Huang <tobyhuang@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Reviewed-by: Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Ben Franz <bfranz@chromium.org> Cr-Commit-Position: refs/heads/main@{#932893}
This patch set prefers-color-scheme according to app's theme after FORCE_DARK_AUTO fail to turn WebView into dark. A developer UI is added to enable force dark in this case, this feature is off by default. Bug: 1253990 Change-Id: Ic302f25e849fbdd737bf23eeef0baa009cdb5aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198856 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/main@{#932894}
images/color-profile-background-image-cross-fade.html images/color-profile-background-clip-text.html virtual/gpu-rasterization/images/color-profile-svg-fill-text.html have been flaky on Linux. Bug: 1256763 Change-Id: Ia52222aa00e53c4383bdbd866a326650f7e14754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229298 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Owners-Override: Melissa Zhang <melzhang@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#932895}
Bug: 1261364 Change-Id: I49544c9b5d3aeb32bf2d37918a7662c200024874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230664 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Owners-Override: Melissa Zhang <melzhang@chromium.org> Auto-Submit: Melissa Zhang <melzhang@chromium.org> Reviewed-by: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/main@{#932896}
WebAuthn navigator.credentials.create should be rejected when it is called in a cross-origin fenced frame. This CL uses GetParentOrOuterDocument instead of GetParent, so that the origin check works correctly for the fenced frame in WebAuthRequestSecurityChecker. Bug: 1248510 Change-Id: I0208a721526b2c5e3377d4450441ab8daf9b687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216395 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#932897}
Roll Chrome Win32 PGO profile from chrome-win32-main-1634612043-298aef9d580892af8fe0e608085648c0530c3628.profdata to chrome-win32-main-1634623137-4155befc375f8834491b75eae5856a070792e8ac.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I231f8bd6363d80258eba51df034326dea3522027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230595 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932898}
AX-Relnotes: n/a Bug: 1068668 Change-Id: Icc1bc1f68d23bec86f6d16567aed19fccf32ebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222585 Commit-Queue: Johan Bay <jobay@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/main@{#932899}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Id12d1d5d916c862c46e5dc29f3a171cae3b474d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230415 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932900}
Bug: 1203071 Change-Id: I2c50f25b569fcae4dc21015d563805bf7168f8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230423 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#932901}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24f3bc7b0727..0b2c2fe242e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: melzhang@google.com Change-Id: Id7c5f29bb8fd4d7665f2213f202cd10c5695e53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230577 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932902}
This reverts commit b4a2e45. Reason for revert: Breaks https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/25174/test-results TutorialTest.TutorialBuilder Original change's description: > Support Hidden steps in TutorialDescription > > complex tutorials require hidden steps. The "must_remain_visible" option > is added from InteractionSequence::Step to support kHidden steps. > > Change-Id: Id90f49ad605c1dd9049ef9d96ca48e09c68c4711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3183021 > Commit-Queue: David Pennington <dpenning@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: Emily Shack <emshack@chromium.org> > Cr-Commit-Position: refs/heads/main@{#932760} Change-Id: I24e5b59ae1cd35b8b59dcd15ad9ca7f2f2711559 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226516 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Owners-Override: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932903}
Change-Id: I95e6ecc9630fa0c5cc17b2f2c755e832836befea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226990 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932904}
Roll Chrome Linux PGO profile from chrome-linux-main-1634601476-408f61a84abcd74694e16f98c049a1ee894daf71.profdata to chrome-linux-main-1634623137-874a4fefd176d4171a7bb4bc8ff749f4f085599c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9c8eea0d9251dcb26d7cd981bcb5043ca4199369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230917 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932905}
collisions in votes uploading Example: field index=1, field name='password', type=NEW_PASSWORD field index=2, field name='password', type=CONFIRMATION_PASSWORD Before this CL, Chrome uploads field index=1, field name='password', type=CONFIRMATION_PASSWORD field index=2, field name='password', type=CONFIRMATION_PASSWORD because Chrome relies on fields' names which can coincide. Thus, the server receives a corrupted vote and cannot classify the form This CL adds a metric that measures the impact of using renderer IDs instead of names. Bug: 1260336 Change-Id: I22c32a85b7feb1d457ee4bfa4657608a9f7c2559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226388 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Matthias Körber <koerber@google.com> Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/main@{#932906}
Remove the COEP:credentialless OT logic and tests. It stopped being used in M95. Bug: 1260920,1175099 Change-Id: I45a0fe099730e77ac196840916ee52d810be426a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229508 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#932907}
Usage is around .01%. See: https://uma.googleplex.com/p/chrome/timeline_v2?sid=ddf48174f8d4cd637a529e840ca3feb7 This is slightly higher than what we would want to enforce this new restriction. I would like to know why website are using this for non malicious purpose. So that we could drive usage down. See intent: https://groups.google.com/a/chromium.org/g/blink-dev/c/yF9j_5gxLgo/m/ofgiGt30AAAJ See UKM collection proposal: https://docs.google.com/document/d/118tI2B4Cwk0bX4cgWKvnWCbbu4sq6un-MGfT90o8Oi4/edit# Note: Firefox's developers said usage is likely dominated by Microsoft Teams with "msteam:" URLs here: whatwg/html#2191 (comment) I would like to get my own data and work with the non malicious actors that would be negatively impacted by this new restriction. Bug: 1253379 Change-Id: I5612b180f120ee5f15747c6b1fb24357356038a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222753 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#932908}
The feature has been approved for 100% Stable launch https://bugs.chromium.org/p/chromium/issues/detail?id=1170364 Bug: 1139263 Change-Id: I8ca7e8958d8c10922d39c4a499a824be87f4a73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229569 Reviewed-by: Maria Kazinova <kazinova@google.com> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/main@{#932909}
…ilable to all platforms." This reverts commit b3c7619. Reason for revert: Breaking https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20(32)%20Tests/73115/test-results with error: failed to resolve infra/python/wheels/pillow/windows-386_cp38_cp38@version:8.3.1 (line 0) Original change's description: > [benchmarking] update pillow version to 8.3.1 and make it available to all platforms. > > The newer version of pillow is needed for using pillow under Python 3. > > The same change has been made on the Catapult repo for a month: > https://chromium-review.googlesource.com/c/catapult/+/3139482 > > Bug: chromium:1260124 > Change-Id: I5153e8f97ff30d68d8caf2e9be884c49599207c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229456 > Reviewed-by: Erik Staab <estaab@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/main@{#932703} Bug: chromium:1260124 Change-Id: I7a5257fea83065515de6351a31be7bd3167e32e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226514 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Owners-Override: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/main@{#932910}
…erty. The spec [1] says the property descriptor returned for the "length" property should not be configurable or enumerable, so stop setting those to true. [1] https://webidl.spec.whatwg.org/#es-observable-array-getOwnPropertyDescriptor Bug: 1201744 Change-Id: I9c8fc71c882a2510d27bd61d34da0ca8a9fc5ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226370 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/main@{#932933}
We use policy to trigger the installation of a desktop PWA, and verify the app is pinned to the shelf. Bug: 1157338,1260178 Change-Id: I6f1c7bcabbeacb196de5efc717aa514431597413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230319 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Reviewed-by: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/main@{#932934}
Roll Chrome Win64 PGO profile from chrome-win64-main-1634623137-0cbab184edf7918c16943a721d8131a2879c41d4.profdata to chrome-win64-main-1634633910-b06cbcc124f7c83edc8719abd96840774a693d60.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia0a0107986e9e6fd022c30c9cf097e232a1b1a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230334 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932935}
Bug: 1187034 Change-Id: Ibc76a2a3ab43f496a804e806fbd827bf916e681a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222750 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#932936}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202110190100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/x2pb5zWOPrnc-BKkcxZ7UJQ4HOkt-NK7bNkL5h5tP-MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/201795212,b/202074799,b/202225574,b/202567011,b/202750715,b/203022666 Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: I37b7e9e76eb5a0674036443d7db26665e3dfb5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230920 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932937}
Code for Media Feeds was removed by https://chromium-review.googlesource.com/c/chromium/src/+/2803838, but some related test code were unexpectedly remaining. This CL is a follow-up to clean them up. Bug: 1053599 Change-Id: I4cab7a542fba3e5f8234152d9fac59ebcfc10a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229326 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#932938}
Also, update settings_toggle_button to allow aria-label attribute to override the label text for screen reader. Bug: 1227380 Test: Manual Test Change-Id: Ia5e1e843d6e1d6e19fd24332273ff2706c10a952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229802 Reviewed-by: dpapad <dpapad@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/main@{#932939}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I3d0f14b8c14117dc42b6d91706e853fa2c6c69a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230600 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932940}
Roll Chrome Win32 PGO profile from chrome-win32-main-1634623137-4155befc375f8834491b75eae5856a070792e8ac.profdata to chrome-win32-main-1634633910-66abed5dc463e1a8156ca57358e0682bceb17b62.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I04409f6b895df0fc69331cb58a5740027e978961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231119 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932941}
This does not appear to be necessary. If we encounter unexpected blocks, it should anyway not match whatever we are trying to parse at the time, and it should fail gracefully from there. Bug: 962417 Change-Id: I9d3b76cafeb43738d8132eb11e3ad310b4535f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194263 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#932942}
…side and takes focus into account Currently, Blink ensures that the focused node in the accessibility tree is never ignored. Since we ultimately want to expose Views as an AXTree of AXNodes, we need to share the same logic with Views and so it cannot be just a Blink only feature. Meanwhile, `AXNode::IsInvisibleOrIgnored()` has similar logic which ensures that nodes that are currently focused are never marked as either invisible or ignored. However, this same logic does not exist in `AXNode::IsIgnored()` creating a confusing inconsistency in the codebase. Importantly, even if the `IsInvisibleOrIgnored` method returns false due to a change in focus, the AXNode could still have stale cached values, such as unignored parent and unignored child count. Clearly, both the AXTree and the AXNode need to update their internal state when a node's ignored state has changed due to either gaining or losing focus. This patch modifies both these classes to do that, while also informing tree observers of the change. This patch also conveniently lays the groundwork for computing the ignored state completely on the browser side in the future, instead of in Blink. This patch is the first of three patches: The second one will switch to using `AXNode::IsIgnored()` across the whole codebase and stop using / completely remove `AXNodeData::IsIgnored()`. The third one will stop creating ignored objects in platform accessibility trees., It will ensure that if an object gets ignored after it has been created, it will be destroyed and if the same object gets unignored again, it will be re-created. R=dmazzoni@chromium.org, aleventhal@chromium.org, kschmi@chromium.org AX-Relnotes: n/a. Bug: 1049261 Change-Id: I69f152e2c903305d08fa16fca7ee1924eb64e298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000745 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/main@{#932943}
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/kwC5wES3I4c This is not shipping the "custom certificate" feature. It's controlled by "WebTransportCustomCertificates". Bug: 1011392 Change-Id: Ic7b402553e5c52b5ec8b9c369769b82809daaa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3208466 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#932944}
Bug: 1258688 Change-Id: I63e38d31c98865179bae67093ae654a98840c151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229741 Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#932945}
The behavior is described in https://jeremyroman.github.io/alternate-loading-modes/prerendering.html#interaction-with-system-focus Bug: 1253158 Change-Id: I292298355d0880160bf78837ed0a8413585f3078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229409 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/main@{#932946}
Previously, these files lived in media/capture/. However, nothing that relies on them lives there; rather, everything related to them lives in third_party/blink/. We therefore move these files. This unblocks the use of WTF::CrossThreadFunction etc. by these files. Bug: 1247761 Change-Id: I625fd18ebeba20cea06f55b04463deae9f821917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222595 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/main@{#932947}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e861e6bcc580..367504f6e4bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: I19b6ae4bf9e7f93c5e15730a111dfac5f9e99969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231097 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932948}
This CL moves 12dp margin around FrameLayout that contains personalized_signin_promo_view_header into personalized_signin_promo_view_header itself. To achieve this, all FrameLayouts that contain personalized_signin_promo_view_header have their margins decreased by 12dp on all sides, while items are changed to keep the position unchanged: * signin_promo_image gets layout_marginTop and layout_marginBottom of 12dp. * signin_promo_close_button size is increased from 24dp to 48dp. This keeps the position of "X" icon the same, but increases the size of the touch target (which is the main goal of this CL). This is a follow-up to https://crrev.com/c/3221051. Bug: 1258822 Change-Id: I2a3a033d114d15fe2cc418d02d2e8c7bd3550776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222959 Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#932949}
This test is failing in these bots: https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-arm64-rel Bug: 1261209 Change-Id: I1d6728df98622bae8ef9c242475504da253c537e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226178 Owners-Override: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/main@{#932950}
Using wpt-import in Chromium 981150c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: If39043e10729971808cdf3f08e0bbdba62c5cb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229191 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932951}
https://chromium.googlesource.com/vulkan-deps.git/+log/86922057daf9..fe06f6ff26f8 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6771daa5c3..f857c9258c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com,jrprice@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: None Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com,jrprice@google.com Change-Id: Id7094934f0b2356db4450611a5cf4cb63e9557d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3230471 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932952}
PartitionAllocMemoryReclaimer runs on the "idle time" task runnerr in renderers. This one (somewhat counter-intuitively) stops as soon as a renderer becomes fully idle. In particular this applies to the case of a renderer getting backgrounded. This increases memory usage for backgrounded renderers. To mitigate that, run a one-off purge. Locally, using pa_tcache_inspect (in //tools/memory) to query the size of empty slot spans, this saves ~400kiB on a news website when moving to background, on Linux. Without this patch, the empty slot span memory stays around for a long time, rather than dropping to 0 after 10s. Bug: 1250288 Change-Id: Ibda8d90377ca162e6da4d999270214c4b2921ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3227760 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#932953}
This CL gets rid of EnableAffiliationBasedMatching method by passing the affiliation service pointer directly to PasswordStore::Init & migrates AffiliatedMatchHelper to PasswordStoreInterface. Bug: 1252350, 1218413 Change-Id: Ibf1369e7bdce829692e57356eaee22970117a1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194138 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: John Wu <jzw@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/main@{#932954}
https://android.googlesource.com/platform/external/perfetto.git/+log/f09923e0f459..997ab09fc74e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71248faa447a34ade84c9f983100b893b65f2d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231020 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932955}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/da51040f6ba0..6b831e3f678c 2021-10-19 kprokopenko@chromium.org Retype incorrect types from UrlString to RawPathString If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1253323 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I557b3e2ea9bddb12ba28e6ba05809990b4cdbca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231117 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#932956}
During the investigation of power consumption it proved useful to know what happens to specific frame requests. The corresponding trace events are in the "cc" category, but enabling this entire category increases trace size substantially. To be able to collect only a required subset of the events, this CL adds a new "raf_investigation" tracing category. Bug: b/202008728 Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Change-Id: I290a95fc6c423f37768a9478fa0937120fcacf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223006 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/main@{#932957}
This CL removes unused imports of deferred-promise-utils.js from window-move.html and window-resize.html. Bug: 1253158 Change-Id: I835545280025ed1a6e3c20ccdd626eb4dec5863f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3231136 Reviewed-by: Lingqi Chi <lingqi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#932958}
Bug: 1259123 Change-Id: I052a7fa3591ddf8e3c730a95d762cca9207789d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222910 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#932959}
From a sandboxed iframe allowing popups, scripts, and same-origin. Open a popup using the WindowProxy of a new iframe that is still on the initial empty document. Check the sandbox flags are properly inherited. Bug: 1256822 Change-Id: I0c21f2b909f61483559ebf22dca1c4369c9fcdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3225890 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#932960}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )