Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile against haskell-src-exts 1.16 #22

Merged
merged 2 commits into from
Apr 3, 2015
Merged

Compile against haskell-src-exts 1.16 #22

merged 2 commits into from
Apr 3, 2015

Conversation

istathar
Copy link
Contributor

Adjust constructors (which are full of nothing but _ anyway) so that hothasktags builds again. Since there's no test suite I can't say whether this is actually been correct, but cursory testing showed the tags file was valid.

Closes #20, maybe.

AfC

@igrep
Copy link

igrep commented Mar 28, 2015

👍

@hesselink
Copy link
Contributor

I just tested this, and it compiles with 1.16.0.1. There's still one incomplete pattern match warning though:

Preprocessing executable 'hothasktags' for hothasktags-0.3.2...
[1 of 1] Compiling Main             ( Main.hs, dist/dist-sandbox-a3afd6ca/build/hothasktags/hothasktags-tmp/Main.o )

Main.hs:37:5: Warning:
    Pattern match(es) are non-exhaustive
    In an equation for ‘extractDeclHead’:
        Patterns not matched: L.DHApp _ _ _

That's probably worth fixing if possible, otherwise people might get runtime crashes.

@istathar
Copy link
Contributor Author

@hesselink done

@hesselink
Copy link
Contributor

@afcowie I tested this, and I now have a version of hothasktags running compiled with this fix. I haven't found any problems with it, so hopefully @luqui can merge this.

luqui added a commit that referenced this pull request Apr 3, 2015
Compile against haskell-src-exts 1.16
@luqui luqui merged commit a5bdf32 into luqui:master Apr 3, 2015
@istathar istathar deleted the fix-src-exts branch April 9, 2015 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't compile with haskell-src-exts 1.16
4 participants