ci: Automatic Nova parameter generation & testing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uter#53) * added CI scrypt for generating pk and compression-snark from Nova repo commit * Changed CI e2e configuration to work with NOVA_URL and NOVA_COMMIT params. Python script changed to work with any version of nova commit. PS: Previous test on nova/src/lib.rs can be removed. * Changed Script name. Return back from generating test in runtime * Changed Script name. Return back from generating test in runtime * Changed Script and CI config. --------- Co-authored-by: Artem <asamblers@gmail.com>
* Remove hardcoded JSONs * Update CI configuration * Drop end2end.yml as it is not relevant for custom branches
samuelburnham
changed the title
storojs72
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I think, generate_contract_input.py and rust-reference-info.env are not relevant in current settings (though eventually we will definitely have e2e verification in main) - since in main we don't have e2e test. And in feature branches they should be overridden
|
Got it, I wasn't sure if we wanted the ability to generate the contract inputs outside of CI. I've removed them and will add the minor changes to the |
storojs72
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testcomment workflow to take input parameters, as seen in theend2end.ymldocumentation.Joint work with @storojs72 and @artem-bakuta
Successful test runs:
argumentcomputer/ci-lab#71
Note
The
end2end.ymlchanges must be merged tomainbefore taking effect. They can be tested with a PR to thepastabranch that contains a validrust-reference-info.env.