Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Edit Cleanup #1

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

meowgorithm
Copy link
Contributor

@meowgorithm meowgorithm commented Jan 10, 2022

Very nice work on this!

This PR contains a couple small edits to keep stuff working properly after Vi/Vim exits:

  • Hide the cursor after exiting the editor (it currently appears in the bottom left corner)
  • Re-enter the altscreen after Vi/Vim exits

As a side note, "open file in external editor" functionality is something we'd ultimately like support in Bubble Tea. There's no timeline for the feature yet, but we can let you know when the feature arrives.

And again: nicely done!

@meowgorithm
Copy link
Contributor Author

Ah—looks like you moved some stuff around right as I was doing this PR. I'll update momentarily.

@meowgorithm meowgorithm changed the title Post edit tidying Post-Edit Cleanup Jan 10, 2022
@meowgorithm
Copy link
Contributor Author

Done!

@lusingander lusingander merged commit 36d5c5a into lusingander:master Jan 10, 2022
@lusingander
Copy link
Owner

lusingander commented Jan 10, 2022

Thanks for the fix!
And thanks for the great library 😉

As a side note, "open file in external editor" functionality is something we'd ultimately like support in Bubble Tea. There's no timeline for the feature yet, but we can let you know when the feature arrives.

That's great!

@meowgorithm meowgorithm deleted the post-edit-tidying branch January 10, 2022 04:53
@mritd
Copy link

mritd commented Jan 11, 2022

Thanks for your reply anyway, I'll try to look at the edist project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants