Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use usize instead of u8 #6

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: Use usize instead of u8 #6

merged 2 commits into from
Jul 29, 2024

Conversation

kdheepak
Copy link
Contributor

Here's the minimum number of changes for converting from u8 to usize, if you are interested in it.

lusingander
lusingander reviewed Jul 29, 2024
View reviewed changes
Copy link
Owner

@lusingander lusingander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, so if you don't mind, could you please fix it so that it passes CI?

src/graph/calc.rs Outdated Show resolved Hide resolved
@lusingander
Copy link
Owner

#4

@kdheepak
Copy link
Contributor Author

I rebased on top of the latest master and resolved the merge conflicts. This should be good to merge now.

lusingander
lusingander approved these changes Jul 29, 2024
View reviewed changes
Copy link
Owner

@lusingander lusingander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lusingander lusingander merged commit 356ff3e into lusingander:master Jul 29, 2024
1 check passed
@kdheepak kdheepak deleted the kd/u8-to-usize branch July 29, 2024 16:11
@lusingander lusingander mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lusingander lusingander lusingander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdheepak @lusingander