Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SegFault #137

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix SegFault #137

merged 3 commits into from
Dec 12, 2023

Conversation

maxirmx
Copy link
Contributor

@maxirmx maxirmx commented Dec 11, 2023

No description provided.

@maxirmx maxirmx linked an issue Dec 12, 2023 that may be closed by this pull request
[BUG] Segmentation fault at 0x0000000000000000 ruby 3.2.1 #129
Closed
@maxirmx
Copy link
Contributor Author

maxirmx commented Dec 12, 2023

Something similar to ruby-rice/rice#173 but not exactly the same case
It was reliably reproducable with Rice gem 4.0 / С++17 standard compilation / Ruby 3.2 but does not occur anymore with Rice 4.1
I guess there is some subtle issue with the code generated by antlr4-native but I did not try to do detailed review.

@maxirmx maxirmx marked this pull request as ready for review December 12, 2023 11:09
@maxirmx maxirmx merged commit a022000 into main Dec 12, 2023
41 checks passed
@maxirmx maxirmx deleted the maxirms-issue-129 branch December 12, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAMOBAP CAMOBAP CAMOBAP approved these changes

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Segmentation fault at 0x0000000000000000 ruby 3.2.1
2 participants
@maxirmx @CAMOBAP