Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) citygml transfer xmi imrovments #86

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

w00lf
Copy link
Contributor

@w00lf w00lf commented Jun 2, 2021

…ation. Support for operations for enum, class, DataType. DataType entity. `children_packages` method for package that includes all pakcages
@@ -1,14 +1,75 @@
# frozen_string_literal: true
require "lutaml/uml/classifier"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line after magic comments.

.gsub(/\\{/, '{')
.split("\n")
.map(&:strip)
.join("\n")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.

.gsub(/\\}/, '}')
.gsub(/\\{/, '{')
.split("\n")
.map(&:strip)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.

.to_s
.gsub(/\\}/, '}')
.gsub(/\\{/, '{')
.split("\n")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.

@definition = value
.to_s
.gsub(/\\}/, '}')
.gsub(/\\{/, '{')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

.to_s
.gsub(/\\}/, '}')
.gsub(/\\{/, '{')
.split("\n")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.

@definition = value
.to_s
.gsub(/\\}/, '}')
.gsub(/\\{/, '{')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

def definition=(value)
@definition = value
.to_s
.gsub(/\\}/, '}')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


def definition=(value)
@definition = value
.to_s
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 16) spaces for indenting an expression in an assignment spanning multiple lines.

end
# rubocop:enable Rails/ActiveRecordAliases

def definition=(value)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method Lutaml::Uml::Value#definition= is defined at both lib/lutaml/uml/value.rb:9 and lib/lutaml/uml/value.rb:19.

@w00lf w00lf merged commit e111f45 into master Jun 2, 2021
@w00lf w00lf deleted the feature/diagram-reference-xmi branch June 2, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants