Reduce the locale drop down in configuration to a fixed list #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not load the installed locales at all; it seems to crash on KDE Plasma. Resolves #5092
…o it works better with a default that has an alias. In particular, if the selected value is on the drop-down list, we need to select it by ID, and then the alias will appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the drop down of locales with a much shorter, fixed list:
The old locale list was enormous, and not very user-friendly. This is a fixed list, including the languages we have translations for in Lutris itself, except Arabic; I don't know what language code to use for that.
Also, the PR throws in Japanese. You know why.
We have been seeing crashes on KDE Plasma that seems to be caused by the big locale list somehow- I hope this will eliminate that crash.
Resolves #5092