Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display better warnings when no recommendations are generated #279

Merged
merged 14 commits into from
Mar 3, 2021

Conversation

jinimukh
Copy link
Member

@jinimukh jinimukh commented Feb 20, 2021

This PR allows the backend to send messages to the frontend API to be displayed as warnings rather than using UserWarnings which do not comply with Pandas Style.
So far, the only case when no recommendations are shown is when none of the default actions can be completed because the data has too few data points.

Changed

  • actions only computed if length of df > 0
  • _data_type set to {} instead of None to enable fetching from an empty dictionary
  • appropriate error messages added
  • removed Pandas fallback
  • adjust some series condition checks

@jinimukh jinimukh marked this pull request as draft February 20, 2021 09:56
@jinimukh jinimukh marked this pull request as ready for review February 26, 2021 21:58
lux/core/frame.py Outdated Show resolved Hide resolved
lux/core/frame.py Outdated Show resolved Hide resolved
lux/core/series.py Outdated Show resolved Hide resolved
@jinimukh jinimukh requested a review from dorisjlee March 3, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants