Adding python-app.yml for Github Action CI #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After we merge this in, we should delete the branch! @dorisjlee |
dorisjlee
reviewed
Mar 5, 2021
| python -m pytest tests/*.py | ||
| - name: Code Coverage Report | ||
| run: | | ||
| pytest --cov-report term --cov=lux tests/ |
There was a problem hiding this comment.
I know that this is probably copied over from what we originally had in the .travis.yml, but it looks like this line rerun the test suite again with the coverage report? The test line runs for about 3 minutes and the code coverage runs for another 4 minutes.
Could we combine this line with the earlier python -m pytest tests/*.py so that we only need to run the test suite once?
|
@dorisjlee This is ready to merge -- failing pytest causes the exit code returned to be 1! |
dorisjlee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes a GitHub Actions File that will take the place of the
.travis.ymlfile.Changes
.github/workflows/python-app.yml.travis.yml