Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration read/write/load API #101

Merged
merged 79 commits into from
May 30, 2021
Merged

Calibration read/write/load API #101

merged 79 commits into from
May 30, 2021

Conversation

saching13
Copy link
Contributor

Added

  • read/write api over xlink.
  • Calibration Handler to load version 6 and 5 of EEPROM data along with manual setters and getters to get the camera intrinsic, extrinsic, distortion coeffs.

Next steps

  • Load EepromData Functionality (No flash)
  • Stereo rectification getters
  • Make stereo Node mode configurable by adding overloading rectification and other required stereo properties.

@saching13
updated shared
04df76d
@saching13
updated shared
c974ee1
@saching13
Merge branch 'gen2_eeprom_api' of github.com:luxonis/depthai-core int…
03e34b9 
…o gen2_eeprom_api
@saching13
added constructor and fetchers headers
d8724b4
@saching13
WIP calibration store example
26c714c 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
@saching13
added setters
2884c3d 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
@saching13
added calibration_stereo example
80fc0f4
@saching13
Added eeprom reader and an example
68ef41f 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
@saching13
added extrinsics getter functions WIP
af20596
@saching13
added more functions test in calibration_reader
19f4df5 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
@saching13
added docstrings and cameraType
4428675 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
@saching13
fixed getIntrinsics bug and Added Device commit id
27b834e
@saching13
updated shared link
9b4c603
@saching13
updated depthai-shared
b763e41
@saching13
merged with develop
968f4e7 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
@saching13
changed commit id and rebased
e44792e
@saching13 saching13 self-assigned this Apr 8, 2021
@saching13
Copy link
Contributor Author

saching13 commented Apr 8, 2021 •
edited
Loading

Make stereo Node mode configurable by adding overloading rectification and other required stereo properties.

On this will do it on a different PR after we finish this, or I can do it after merging this in stereo fixes PR of @alex-luxonis

themarpe
themarpe requested changes Apr 10, 2021
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

examples/src/bootloader_example.cpp Outdated Show resolved Hide resolved
examples/src/calibration_from_file.cpp Outdated Show resolved Hide resolved
examples/src/calibration_reader.cpp Outdated Show resolved Hide resolved
examples/src/calibration_reader.cpp Outdated Show resolved Hide resolved
examples/src/calibration_storer.cpp Outdated Show resolved Hide resolved
src/device/Device.cpp Outdated Show resolved Hide resolved
src/device/CalibrationHandler.cpp Outdated Show resolved Hide resolved
src/device/CalibrationHandler.cpp Show resolved Hide resolved
src/device/CalibrationHandler.cpp Outdated Show resolved Hide resolved
src/device/CalibrationHandler.cpp Outdated Show resolved Hide resolved
@saching13
local commit
f76f8a5 
Signed-off-by: Sachin <sachin.guruswamy@gmail.com>
themarpe
themarpe previously requested changes May 28, 2021
View reviewed changes
examples/src/calibration_flash.cpp Outdated Show resolved Hide resolved
examples/src/calibration_load.cpp Outdated Show resolved Hide resolved
include/depthai/device/Device.hpp Outdated Show resolved Hide resolved
src/device/Device.cpp Outdated Show resolved Hide resolved
saching13
saching13 commented May 29, 2021
View reviewed changes
Copy link
Contributor Author

@saching13 saching13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szabi-luxonis and @themarpe Can you cross-check and approve it if all good?

@saching13
Copy link
Contributor Author

Cannot merge this. Need approval from @szabi-luxonis and @themarpe

@saching13 saching13 dismissed stale reviews from themarpe and SzabolcsGergely May 30, 2021 03:06

Addressed requested changes

@saching13 saching13 merged commit aa07285 into develop May 30, 2021
@saching13 saching13 deleted the gen2_eeprom_api branch May 30, 2021 04:03
@alex-luxonis
Copy link
Contributor

It appears this firmware fixes the slight shifting issue between RGB and depth, with RGB-depth alignment enabled. 👍

@Luxonis-Brandon
Copy link
Contributor

Sweet!

@Luxonis-Brandon Luxonis-Brandon added enhancement New feature or request Gen2 Feature for or issue with Gen2 labels May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawel-pieniazek pawel-pieniazek pawel-pieniazek left review comments

@alex-luxonis alex-luxonis alex-luxonis approved these changes

@Luxonis-Brandon Luxonis-Brandon Awaiting requested review from Luxonis-Brandon

@themarpe themarpe Awaiting requested review from themarpe

@SzabolcsGergely SzabolcsGergely Awaiting requested review from SzabolcsGergely

Assignees

@saching13 saching13

Labels
enhancement New feature or request Gen2 Feature for or issue with Gen2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saching13 @alex-luxonis @SzabolcsGergely @Luxonis-Brandon @pawel-pieniazek @themarpe