Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save calibration & board config to EEPROM #56

Merged
merged 6 commits into from
Apr 13, 2020
Merged

Conversation

alex-luxonis
Copy link
Collaborator

New options added to depthai.py:

  -fv FIELD_OF_VIEW, --field-of-view FIELD_OF_VIEW
                        Field of view for the stereo cameras in [deg]
  -b BASELINE, --baseline BASELINE
                        Left/Right camera baseline in [cm]
  -r RGB_BASELINE, --rgb-baseline RGB_BASELINE
                        Distance the RGB camera is from the Left camera
  -w, --no-swap-lr      Do not swap the Left and Right cameras
  -e, --store-eeprom    Store the calibration and board_config (fov,
                        baselines, swap-lr) in the EEPROM onboard
  --clear-eeprom        Invalidate the calib and board_config from EEPROM
  -o, --override-calib  Use the calib and board_config from host, ignoring the
                        EEPROM data if programmed

New options added to calibrate.py:

  -fv FIELD_OF_VIEW, --field-of-view FIELD_OF_VIEW
                        Field of view for the stereo cameras in [deg]
  -b BASELINE, --baseline BASELINE
                        Left/Right camera baseline in [cm]
  -w, --no-swap-lr      Do not swap the Left and Right cameras

@Luxonis-Brandon
Copy link
Contributor

Thanks @alex-luxonis ! So quick question on field of view... is that diagonal or horizontal?

@Luxonis-Brandon
Copy link
Contributor

So other than specifying which FOV this means, this LGTM. And @Luxonis-Brian checked it out and it LGTH as well. So I'd say feel free to go with this @alex-luxonis !

@Luxonis-Brian
Copy link
Contributor

The horizontal FOV should actually be 71.86, and the vertical should be 56.74.

@alex-luxonis alex-luxonis merged commit 71693b0 into master Apr 13, 2020
@alex-luxonis alex-luxonis deleted the eeprom_calib branch April 13, 2020 21:36
@alex-luxonis
Copy link
Collaborator Author

Note depthai_usb2.cmd was not rebuilt here!

@Luxonis-Brandon
Copy link
Contributor

Should we do that for now @alex-luxonis or should we do one of the approaches for supporting USB2-only that you or Szabi mentioned the other day?

SzabolcsGergely pushed a commit that referenced this pull request Oct 30, 2020
Save calibration & board config to EEPROM
jdavidberger pushed a commit to constructiverealities/depthai that referenced this pull request May 26, 2022
Reduce memory allocations by using the nodeMap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants