Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url::toMenuItem alternative for nav_id #61

Closed
TheMaaarc opened this issue Apr 9, 2018 · 2 comments
Closed

Url::toMenuItem alternative for nav_id #61

TheMaaarc opened this issue Apr 9, 2018 · 2 comments
Assignees
@nadar
Labels
enhancement

Comments

@TheMaaarc
Copy link
Member

Create an alternative function to generate a link to a menuItem by navId. Url::toMenuItem searches by the actual id that is only visible in the database.
@nadar
Copy link
Member

nadar commented Apr 9, 2018

Agree, lets add: luya\cms\helpers\Url::toMenu($navId, [])

@nadar
Copy link
Member

nadar commented Apr 9, 2018

Mabye also consider rename toMenu with toNav also for toMenuItem as toNavItem.

nadar added a commit that referenced this issue Apr 9, 2018
@nadar
Deprecated method toNavItem() in class luya\cms\helpers\Url in fa…
fd11783 
…vor of `toMenuNavItem()` and also added new method `toMenuNav()`. #61
TheMaaarc added a commit that referenced this issue Apr 10, 2018
@TheMaaarc
Removed old and undefined variable $params #61
aaf1e54
@nadar nadar closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nadar @TheMaaarc